From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id CAB6A1F5
 for <dev@dpdk.org>; Sun,  2 Jul 2017 21:19:24 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 02 Jul 2017 12:19:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,299,1496127600"; d="scan'208";a="987928536"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by orsmga003.jf.intel.com with ESMTP; 02 Jul 2017 12:19:22 -0700
Received: from irsmsx104.ger.corp.intel.com ([169.254.5.26]) by
 IRSMSX151.ger.corp.intel.com ([169.254.4.191]) with mapi id 14.03.0319.002;
 Sun, 2 Jul 2017 20:19:22 +0100
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Rao, Nikhil" <nikhil.rao@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] ethdev: fix a typo in eth device API doc
Thread-Index: AQHR67lPYyMs43Y960m9vqgitu7v1qI/iDUQgANGmQCAAClZwA==
Date: Sun, 2 Jul 2017 19:19:20 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE23ED1DE40@IRSMSX104.ger.corp.intel.com>
References: <1470030588-7825-1-git-send-email-nikhil.rao@intel.com>
 <B27915DBBA3421428155699D51E4CFE23ED1C3FC@IRSMSX104.ger.corp.intel.com>
 <9396121.kvQzYzBiED@xps>
In-Reply-To: <9396121.kvQzYzBiED@xps>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTk0OWQ0NTMtZjI3Yi00ZTAxLTlkZDYtN2U2YjQzODA4ODJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlYraTl3RHhraElJQ3FYSkN5SUI2Y0hTVWRQZlRMT0tkK2NZZUR6WjZuSVE9In0=
dlp-product: dlpe-windows
dlp-version: 10.0.102.7
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix a typo in eth device API doc
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Jul 2017 19:19:25 -0000

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Sunday, July 2, 2017 6:49 PM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Rao, Nikhil <nikhil.rao@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix a typo in eth device API doc
>=20
> 30/06/2017 16:47, Mcnamara, John:
> > >
> > > This patch fixes a typo in the eth device API doc, device config.
> > > not stored between calls to rte_eth_dev_start/stop() should be
> > > restored before a call to rte_eth_dev_start() instead of after a
> > > call to rte_eth_dev_start().
> > >
> > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> >
> > Acked-by: John McNamara <john.mcnamara@intel.com>
>=20
> I am still not convinced by this whole text, but applied to move forward.

Agreed. We should mark this as a defect and have someone re-evaluate the
overall text. However, in terms of this patch, at least it is less wrong th=
an
the existing text.