Re: [dpdk-dev] [PATCH 1/2] doc: add details of rte_flow security actions

["Mcnamara, John" <john.mcnamara@intel.com>]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Boris Pismenny
> Sent: Sunday, September 17, 2017 1:07 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Doherty, Declan <declan.doherty@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> hemant.agrawal@nxp.com; Nicolau, Radu <radu.nicolau@intel.com>;
> borisp@mellanox.com; aviadye@mellanox.com; thomas@monjalon.net;
> sandeep.malik@nxp.com; jerin.jacob@caviumnetworks.com;
> nelio.laranjeiro@6wind.com; liranl@mellanox.com
> Subject: [dpdk-dev] [PATCH 1/2] doc: add details of rte_flow security
> actions
> 
> Signed-off-by: Boris Pismenny <borisp@mellanox.com>


Thanks for the docs. Minor comments below.



> +
> +Multiple flows can be configured to use the same security session.
> +
> +- Non-terminating by default.

This is a single bullet point list and it seems disconnected from the previous
line. Maybe convert it to a sentence instead.



> +
> +.. _table_rte_flow_action_security

This is missing a colon at the end and causes a doc build warning.


> +Usage example, configure IPsec inline using INLINE_CRYPTO security
> session:

This doesn't seem to connect to the following paragraph. Maybe something
like:

    The following is an example of configuring IPsec inline using the
    INLINE_CRYPTO security session:

Reviewed-by: John McNamara <john.mcnamara@intel.com>