From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C7352199A9 for ; Mon, 18 Sep 2017 13:14:33 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 04:14:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,412,1500966000"; d="scan'208";a="312872518" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga004.fm.intel.com with ESMTP; 18 Sep 2017 04:14:30 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by IRSMSX108.ger.corp.intel.com ([169.254.11.167]) with mapi id 14.03.0319.002; Mon, 18 Sep 2017 12:14:29 +0100 From: "Mcnamara, John" To: Boris Pismenny , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Doherty, Declan" , "De Lara Guarch, Pablo" , "hemant.agrawal@nxp.com" , "Nicolau, Radu" , "aviadye@mellanox.com" , "thomas@monjalon.net" , "sandeep.malik@nxp.com" , "jerin.jacob@caviumnetworks.com" , "nelio.laranjeiro@6wind.com" , "liranl@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH 1/2] doc: add details of rte_flow security actions Thread-Index: AQHTL65lMc6iAS6PFEqrTW0KNOyudKK6fGzA Date: Mon, 18 Sep 2017 11:14:29 +0000 Message-ID: References: <1505649991-3463-1-git-send-email-borisp@mellanox.com> <1505649991-3463-2-git-send-email-borisp@mellanox.com> In-Reply-To: <1505649991-3463-2-git-send-email-borisp@mellanox.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjkwZjE0ZjItNDJjZC00MTBjLTk5ZTgtNzhjMGNlYTIzOTkzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlRZS3NGZWtYdDZVb3dzZko4Q1ZpcEE0VnRtTXNIZURLV3BoVVZ3OWd3UHc9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] doc: add details of rte_flow security actions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 11:14:34 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Boris Pismenny > Sent: Sunday, September 17, 2017 1:07 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; > hemant.agrawal@nxp.com; Nicolau, Radu ; > borisp@mellanox.com; aviadye@mellanox.com; thomas@monjalon.net; > sandeep.malik@nxp.com; jerin.jacob@caviumnetworks.com; > nelio.laranjeiro@6wind.com; liranl@mellanox.com > Subject: [dpdk-dev] [PATCH 1/2] doc: add details of rte_flow security > actions >=20 > Signed-off-by: Boris Pismenny Thanks for the docs. Minor comments below. > + > +Multiple flows can be configured to use the same security session. > + > +- Non-terminating by default. This is a single bullet point list and it seems disconnected from the previ= ous line. Maybe convert it to a sentence instead. > + > +.. _table_rte_flow_action_security This is missing a colon at the end and causes a doc build warning. > +Usage example, configure IPsec inline using INLINE_CRYPTO security > session: This doesn't seem to connect to the following paragraph. Maybe something like: The following is an example of configuring IPsec inline using the INLINE_CRYPTO security session: Reviewed-by: John McNamara