From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 9F8DE237 for ; Mon, 18 Sep 2017 15:40:40 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 18 Sep 2017 06:40:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,413,1500966000"; d="scan'208";a="1220308934" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga002.fm.intel.com with ESMTP; 18 Sep 2017 06:40:37 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 18 Sep 2017 14:40:36 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by IRSMSX156.ger.corp.intel.com ([169.254.3.33]) with mapi id 14.03.0319.002; Mon, 18 Sep 2017 14:40:36 +0100 From: "Mcnamara, John" To: Shahaf Shuler , "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" , "Ananyev, Konstantin" , "arybchenko@solarflare.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 3/3] doc: add details on ethdev offloads API Thread-Index: AQHTL4ICHADixh07oEOIisw9TZo9CKK6piDg Date: Mon, 18 Sep 2017 13:40:35 +0000 Message-ID: References: <6b4402ed833f9edb53c907e77f38130434d8b40a.1505630554.git.shahafs@mellanox.com> In-Reply-To: <6b4402ed833f9edb53c907e77f38130434d8b40a.1505630554.git.shahafs@mellanox.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTZkZTczYmItM2QxNi00OTQ4LTk1OWYtN2QzZjMwMGU4NmE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InlTMUtSaE9KekwySlR3S3NCR0x1QTByUW01Sk1UY2xPalJYTUxDNDI1YTA9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 3/3] doc: add details on ethdev offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 13:40:42 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Sunday, September 17, 2017 7:55 AM > To: thomas@monjalon.net; jerin.jacob@caviumnetworks.com; Ananyev, > Konstantin ; arybchenko@solarflare.com > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v4 3/3] doc: add details on ethdev offloads AP= I >=20 > Add the programmers guide details on the new offloads API introduced by > commits: >=20 > commit f649472cad9d ("ethdev: introduce Rx queue offloads API") commit > ecb46b66cda5 ("ethdev: introduce Tx queue offloads API") >=20 > Signed-off-by: Shahaf Shuler > ... > +Per-Port and Per-Queue Offloads > +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > + > +On DPDK 17.11, a new offloads API was introduced. It is best to omit this line. There are a number of small grammatical errors in the rest of the text. Probably something like this would be better: Per-Port and Per-Queue Offloads ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ In the DPDK offload API, offloads are divided into per-port and per-queue o= ffloads. The different offloads capabilities can be queried using ``rte_eth_dev_info= _get()``. Supported offloads can be either per-port or per-queue. Offloads are enabled using the existing ``DEV_TX_OFFLOAD_*`` or ``DEV_RX_OF= FLOAD_*`` flags. Per-port offload configuration is set using ``rte_eth_dev_configure``. Per-queue offload configuration is set using ``rte_eth_rx_queue_setup`` and= ``rte_eth_tx_queue_setup``. To enable per-port offload, the offload should be set on both device config= uration and queue setup. In case of a mixed configuration the queue setup shall return with an error= . To enable per-queue offload, the offload can be set only on the queue setup= . Offloads which are not enabled are disabled by default. For an application to use the Tx offloads API it should set the ``ETH_TXQ_F= LAGS_IGNORE`` flag in the ``txq_flags`` field located in ``rte_eth_txconf``= struct. In such cases it is not required to set other flags in ``txq_flags``. In such cases it is not required to set other bitfield offloads in the ``rx= mode`` struct. For an application to use the Rx offloads API it should set the ``ignore_of= fload_bitfield`` bit in the ``rte_eth_rxmode`` struct. Reviewed-by: John McNamara