DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Kovacevic, Marko" <marko.kovacevic@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 2/2] doc: add new introduction to sample app guides
Date: Thu, 5 Oct 2017 17:48:26 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23EDBB367@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1507201957-237765-2-git-send-email-marko.kovacevic@intel.com>



> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Thursday, October 5, 2017 12:13 PM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>
> Subject: [PATCH v4 2/2] doc: add new introduction to sample app guides
> 
> Add new Introduction Section into the sample app guides.
> 
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>

Hi,

Some minor comments below.


>...

> +Introduction to the DPDK Sample Applications
> +============================================
> +
> +This article describes the Data Plane Development Kit Sample
> Applications.

This first line can be omitted.


> +
> +The DPDK Sample Applications are small standalone applications which
> +demonstrate various features of DPDK. They can be considered a cookbook
> of DPDK features.
> +User interested in getting started with DPDK can take the applications,
> +try out the features, and then extend them to fit their needs.

s/User/Users/


> +
> +
> +The DPDK Sample Applications
> +----------------------------
> +
> + .. _table_:
> + .. table:: **Some of the DPDK Sample applications**


The _table_ target should be more unique such as: _table_sample_apps


> +
> +These examples range from simple to reasonable complex but most are


s/reasonable/reasonably/

> +The Hello
> +  World example sets up the DPDK Environment Abstraction Layer (EAL),
> +and prints a
> +  simple "Hello World" message to each of the DPDK enabled cores. This
> +  applicatioin doesn’t do any packet formatting but it is a good way to


s/applicatioin/application/


Reviewed-by: John McNamara <john.mcnamara@intel.com>



  reply	other threads:[~2017-10-05 17:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 11:12 [dpdk-dev] [PATCH v4 1/2] doc: add generic compilation doc for all sample apps Marko Kovacevic
2017-10-05 11:12 ` [dpdk-dev] [PATCH v4 2/2] doc: add new introduction to sample app guides Marko Kovacevic
2017-10-05 17:48   ` Mcnamara, John [this message]
2017-10-05 17:26 ` [dpdk-dev] [PATCH v4 1/2] doc: add generic compilation doc for all sample apps Mcnamara, John
2017-10-09 16:19 ` [dpdk-dev] [PATCH v5 " Marko Kovacevic
2017-10-09 16:19   ` [dpdk-dev] [PATCH v5 2/2] doc: add new introduction to sample app guides Marko Kovacevic
2017-10-09 16:50     ` Mcnamara, John
2017-10-09 16:48   ` [dpdk-dev] [PATCH v5 1/2] doc: add generic compilation doc for all sample apps Mcnamara, John
2017-10-11 15:51   ` [dpdk-dev] [PATCH v6 " Marko Kovacevic
2017-10-11 15:51     ` [dpdk-dev] [PATCH v6 2/2] doc: add new introduction to sample app guides Marko Kovacevic
2017-10-12 10:55       ` Mcnamara, John
2017-10-13 22:17       ` Thomas Monjalon
2017-10-16 14:50       ` [dpdk-dev] [PATCH v7 1/2] doc: add generic compilation doc for all sample apps Marko Kovacevic
2017-10-16 14:50         ` [dpdk-dev] [PATCH v7 2/2] doc: add new introduction to sample app guides Marko Kovacevic
2017-10-16 18:53           ` Mcnamara, John
2017-10-18  9:28           ` [dpdk-dev] [PATCH v8 1/2] doc: add generic compilation doc for all sample apps Marko Kovacevic
2017-10-18  9:28             ` [dpdk-dev] [PATCH v8 2/2] doc: add new introduction to sample app guides Marko Kovacevic
2017-10-12 10:55     ` [dpdk-dev] [PATCH v6 1/2] doc: add generic compilation doc for all sample apps Mcnamara, John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE23EDBB367@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=marko.kovacevic@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).