From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 956C61B1B0 for ; Mon, 9 Oct 2017 11:28:53 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2017 02:28:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,500,1500966000"; d="scan'208";a="160494973" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga005.fm.intel.com with ESMTP; 09 Oct 2017 02:28:51 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Oct 2017 10:28:50 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by irsmsx155.ger.corp.intel.com ([169.254.14.169]) with mapi id 14.03.0319.002; Mon, 9 Oct 2017 10:28:50 +0100 From: "Mcnamara, John" To: "Singh, Jasvinder" , "Iremonger, Bernard" , "dev@dpdk.org" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "Dumitrescu, Cristian" , "adrien.mazarguil@6wind.com" CC: "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH v7 1/4] librte_flow_classify: add librte_flow_classify library Thread-Index: AQHTPrP8L4HwfPnAxEq+x6dUVvyZ56LbRBSg Date: Mon, 9 Oct 2017 09:28:49 +0000 Message-ID: References: <1506676737-23900-1-git-send-email-bernard.iremonger@intel.com> <1506936668-31197-2-git-send-email-bernard.iremonger@intel.com> <54CBAA185211B4429112C315DA58FF6D33264ABA@IRSMSX103.ger.corp.intel.com> In-Reply-To: <54CBAA185211B4429112C315DA58FF6D33264ABA@IRSMSX103.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzlhNmNiMjctMjBjZC00ZmYyLTliN2YtZjkwNGRjYmU0MWY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImpNZ1BQVUpSWHVvTjQ0NlVwTWplTlJQbXQ0aWFlUlpaNmhvYjNUZEVyeDg9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 1/4] librte_flow_classify: add librte_flow_classify library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 09:28:54 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Singh, Jasvinder > Sent: Friday, October 6, 2017 4:01 PM > To: Iremonger, Bernard ; dev@dpdk.org; Yigit= , > Ferruh ; Ananyev, Konstantin > ; Dumitrescu, Cristian > ; adrien.mazarguil@6wind.com > Cc: Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH v7 1/4] librte_flow_classify: add > librte_flow_classify library >=20 > ... > > The API in its current form creates the classifier object which will > always use librte_acl based classification mechanism. This behavior > imposes restriction on the application to always pass only ACL table > related parameters for flow classification. In my opinion, API > implementation should be agnostic to specific classification method and > should be generic enough to allow application to select any of the > available flow classification method (for e.g. acl, hash, LPM, etc.). > Otherwise, this library will become another abstraction of librte_acl for > flow classification. >=20 > Also, library allows table entries to be added while creating the > classifier object, not later. Is there any specific reason? Hi, I think that we should fix this prior to merge. Can we make these changes a= nd target RC2 instead. John