From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Kovacevic, Marko" <marko.kovacevic@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 1/2] doc: add generic compilation doc for all sample apps
Date: Mon, 9 Oct 2017 16:48:59 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23EDC58E1@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1507565946-223643-1-git-send-email-marko.kovacevic@intel.com>
> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Monday, October 9, 2017 5:19 PM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>; Herakliusz
> Lipiec <herakliusz.lipiec@intel.com>
> Subject: [PATCH v5 1/2] doc: add generic compilation doc for all sample
> apps
>
> From: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
>
> Moved duplicated, and occasionally outdated, doc sections from each of the
> sample app guides chapters to a common chapter at the start.
>
> This reduces the duplication in the docs and provides a single point of
> reference for compiling the sample apps.
>
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> Reviewed-by: John McNamara <john.mcnamara@intel.com>
I think there was is a line or two missing in the "single application" instructions.
Also, since the original patch there are 2 new sample applications that should
be fixed as well:
* vhost_scsi
* eventdev_pipeline_sw_pmd
Also, the tep_termination doc could be updated.
John
next prev parent reply other threads:[~2017-10-09 16:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 11:12 [dpdk-dev] [PATCH v4 " Marko Kovacevic
2017-10-05 11:12 ` [dpdk-dev] [PATCH v4 2/2] doc: add new introduction to sample app guides Marko Kovacevic
2017-10-05 17:48 ` Mcnamara, John
2017-10-05 17:26 ` [dpdk-dev] [PATCH v4 1/2] doc: add generic compilation doc for all sample apps Mcnamara, John
2017-10-09 16:19 ` [dpdk-dev] [PATCH v5 " Marko Kovacevic
2017-10-09 16:19 ` [dpdk-dev] [PATCH v5 2/2] doc: add new introduction to sample app guides Marko Kovacevic
2017-10-09 16:50 ` Mcnamara, John
2017-10-09 16:48 ` Mcnamara, John [this message]
2017-10-11 15:51 ` [dpdk-dev] [PATCH v6 1/2] doc: add generic compilation doc for all sample apps Marko Kovacevic
2017-10-11 15:51 ` [dpdk-dev] [PATCH v6 2/2] doc: add new introduction to sample app guides Marko Kovacevic
2017-10-12 10:55 ` Mcnamara, John
2017-10-13 22:17 ` Thomas Monjalon
2017-10-16 14:50 ` [dpdk-dev] [PATCH v7 1/2] doc: add generic compilation doc for all sample apps Marko Kovacevic
2017-10-16 14:50 ` [dpdk-dev] [PATCH v7 2/2] doc: add new introduction to sample app guides Marko Kovacevic
2017-10-16 18:53 ` Mcnamara, John
2017-10-18 9:28 ` [dpdk-dev] [PATCH v8 1/2] doc: add generic compilation doc for all sample apps Marko Kovacevic
2017-10-18 9:28 ` [dpdk-dev] [PATCH v8 2/2] doc: add new introduction to sample app guides Marko Kovacevic
2017-10-12 10:55 ` [dpdk-dev] [PATCH v6 1/2] doc: add generic compilation doc for all sample apps Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23EDC58E1@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=herakliusz.lipiec@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).