From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CB2351B018 for ; Wed, 17 Jan 2018 17:35:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2018 08:35:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,372,1511856000"; d="scan'208";a="20166660" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga003.jf.intel.com with ESMTP; 17 Jan 2018 08:35:26 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.138]) by irsmsx105.ger.corp.intel.com ([169.254.7.236]) with mapi id 14.03.0319.002; Wed, 17 Jan 2018 16:35:25 +0000 From: "Mcnamara, John" To: "Yigit, Ferruh" , "Richardson, Bruce" , "Kovacevic, Marko" CC: "dev@dpdk.org" , "Varghese, Vipin" , "Glynn, Michael J" Thread-Topic: [PATCH] doc: update pcap documentation Thread-Index: AQHTjvpDXwEgu2KW1kKm1PIhxZMeVqN4Q8ZQ Date: Wed, 17 Jan 2018 16:35:24 +0000 Message-ID: References: <20180116184528.5498-1-ferruh.yigit@intel.com> In-Reply-To: <20180116184528.5498-1-ferruh.yigit@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWJjZDMyOWUtZDU2ZS00MzIxLTg5ZjAtYTg1ZGYzYjg2MmNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImFQbXVWdDJTSnZyamp6emFOblRWeG1qYzM2YU1JZHVjbk90VXIzK3Q3YUE9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: update pcap documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 16:35:29 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, January 16, 2018 6:45 PM > To: Richardson, Bruce ; Mcnamara, John > ; Kovacevic, Marko > Cc: dev@dpdk.org; Yigit, Ferruh ; Varghese, Vipin > ; Glynn, Michael J > Subject: [PATCH] doc: update pcap documentation >=20 > Add note about PMD expects the network interfaces provided to be up, > documented behavior to set expectations right. >=20 > Also added minor fix. >=20 >... >=20 > +Notes > +^^^^^ > + > +The network interface provided to the PMD should be up, PMD will return > +an error if interface is down, and PMD itself won't change the status of > the external network interface. It would probably be a little better as an RST note directive, as used else= where in the doc. Like this: .. note:: The network interface provided to the PMD should be up. The PMD will ret= urn an error if interface is down, and the PMD itself won't change the statu= s of the external network interface. But it isn't a big issue so: Acked-by: John McNamara