[dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Marko Kovacevic]

Added SPDX headers to doc files to have them aligned with
the other doc files.

Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
 doc/guides/contributing/cheatsheet.rst           | 3 +++
 doc/guides/contributing/coding_style.rst         | 3 +++
 doc/guides/contributing/design.rst               | 3 +++
 doc/guides/contributing/documentation.rst        | 3 +++
 doc/guides/contributing/img/patch_cheatsheet.svg | 3 ++-
 doc/guides/contributing/index.rst                | 3 +++
 doc/guides/contributing/patches.rst              | 3 +++
 doc/guides/contributing/stable.rst               | 3 +++
 doc/guides/contributing/versioning.rst           | 3 +++
 doc/guides/linux_gsg/nic_perf_intel_platform.rst | 3 +++
 doc/guides/rel_notes/deprecation.rst             | 3 +++
 doc/guides/rel_notes/release_16_04.rst           | 3 +++
 doc/guides/rel_notes/release_16_07.rst           | 3 +++
 doc/guides/rel_notes/release_16_11.rst           | 3 +++
 doc/guides/rel_notes/release_17_02.rst           | 3 +++
 doc/guides/rel_notes/release_17_05.rst           | 3 +++
 doc/guides/rel_notes/release_17_08.rst           | 3 +++
 doc/guides/rel_notes/release_17_11.rst           | 3 +++
 doc/guides/rel_notes/release_18_02.rst           | 3 +++
 doc/guides/rel_notes/release_2_2.rst             | 3 +++
 20 files changed, 59 insertions(+), 1 deletion(-)

diff --git a/doc/guides/contributing/cheatsheet.rst b/doc/guides/contributing/cheatsheet.rst
index 7bc0771..97512d7 100644
--- a/doc/guides/contributing/cheatsheet.rst
+++ b/doc/guides/contributing/cheatsheet.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 Patch Cheatsheet
 ================
 
diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
index b0f0adb..e285fc8 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 .. _coding_style:
 
 DPDK Coding Style
diff --git a/doc/guides/contributing/design.rst b/doc/guides/contributing/design.rst
index 88d3a43..bbe219e 100644
--- a/doc/guides/contributing/design.rst
+++ b/doc/guides/contributing/design.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 Design
 ======
 
diff --git a/doc/guides/contributing/documentation.rst b/doc/guides/contributing/documentation.rst
index 82f2e1b..7ac1b41 100644
--- a/doc/guides/contributing/documentation.rst
+++ b/doc/guides/contributing/documentation.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 .. _doc_guidelines:
 
 DPDK Documentation Guidelines
diff --git a/doc/guides/contributing/img/patch_cheatsheet.svg b/doc/guides/contributing/img/patch_cheatsheet.svg
index 8522592..af2473d 100644
--- a/doc/guides/contributing/img/patch_cheatsheet.svg
+++ b/doc/guides/contributing/img/patch_cheatsheet.svg
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<!-- Created with Inkscape (http://www.inkscape.org/) -->
+<!-- SPDX-License-Identifier: BSD-3-Clause -->
+<!-- Copyright(c) 2018 Intel Corporation -->
 
 <svg
    xmlns:dc="http://purl.org/dc/elements/1.1/"
diff --git a/doc/guides/contributing/index.rst b/doc/guides/contributing/index.rst
index 329b678..9fa0076 100644
--- a/doc/guides/contributing/index.rst
+++ b/doc/guides/contributing/index.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 Contributor's Guidelines
 ========================
 
diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
index 2287835..494cdf4 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 .. submitting_patches:
 
 Contributing Code to DPDK
diff --git a/doc/guides/contributing/stable.rst b/doc/guides/contributing/stable.rst
index 0f2f1f3..16518b0 100644
--- a/doc/guides/contributing/stable.rst
+++ b/doc/guides/contributing/stable.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 .. stable_lts_releases:
 
 DPDK Stable Releases and Long Term Support
diff --git a/doc/guides/contributing/versioning.rst b/doc/guides/contributing/versioning.rst
index c495294d..6e2f073 100644
--- a/doc/guides/contributing/versioning.rst
+++ b/doc/guides/contributing/versioning.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 Managing ABI updates
 ====================
 
diff --git a/doc/guides/linux_gsg/nic_perf_intel_platform.rst b/doc/guides/linux_gsg/nic_perf_intel_platform.rst
index 987cd0a..7bd05b6 100644
--- a/doc/guides/linux_gsg/nic_perf_intel_platform.rst
+++ b/doc/guides/linux_gsg/nic_perf_intel_platform.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 How to get best performance with NICs on Intel platforms
 ========================================================
 
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ec70b5f..a8bd787 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 ABI and API Deprecation
 =======================
 
diff --git a/doc/guides/rel_notes/release_16_04.rst b/doc/guides/rel_notes/release_16_04.rst
index d0a09ef..072b294 100644
--- a/doc/guides/rel_notes/release_16_04.rst
+++ b/doc/guides/rel_notes/release_16_04.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 DPDK Release 16.04
 ==================
 
diff --git a/doc/guides/rel_notes/release_16_07.rst b/doc/guides/rel_notes/release_16_07.rst
index a8a3fc1..e8aea7a 100644
--- a/doc/guides/rel_notes/release_16_07.rst
+++ b/doc/guides/rel_notes/release_16_07.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 DPDK Release 16.07
 ==================
 
diff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst
index 8c9ec65..551e1d5 100644
--- a/doc/guides/rel_notes/release_16_11.rst
+++ b/doc/guides/rel_notes/release_16_11.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 DPDK Release 16.11
 ==================
 
diff --git a/doc/guides/rel_notes/release_17_02.rst b/doc/guides/rel_notes/release_17_02.rst
index 357965a..f6c1b91 100644
--- a/doc/guides/rel_notes/release_17_02.rst
+++ b/doc/guides/rel_notes/release_17_02.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 DPDK Release 17.02
 ==================
 
diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst
index 6892284..9550cd5 100644
--- a/doc/guides/rel_notes/release_17_05.rst
+++ b/doc/guides/rel_notes/release_17_05.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 DPDK Release 17.05
 ==================
 
diff --git a/doc/guides/rel_notes/release_17_08.rst b/doc/guides/rel_notes/release_17_08.rst
index 0bcdfb7..f2cf434 100644
--- a/doc/guides/rel_notes/release_17_08.rst
+++ b/doc/guides/rel_notes/release_17_08.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 DPDK Release 17.08
 ==================
 
diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
index c2e3fc3..d0e2c6f 100644
--- a/doc/guides/rel_notes/release_17_11.rst
+++ b/doc/guides/rel_notes/release_17_11.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 DPDK Release 17.11
 ==================
 
diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst
index 44b7de5..b2b207a 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 DPDK Release 18.02
 ==================
 
diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst
index bb7d15a..8baccfb 100644
--- a/doc/guides/rel_notes/release_2_2.rst
+++ b/doc/guides/rel_notes/release_2_2.rst
@@ -1,3 +1,6 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright(c) 2018 Intel Corporation
+
 DPDK Release 2.2
 ================
 
-- 
2.9.5

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Ferruh Yigit]

On 4/9/2018 2:11 PM, Marko Kovacevic wrote:
> Added SPDX headers to doc files to have them aligned with
> the other doc files.
> 
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>

<...>

>  doc/guides/rel_notes/release_16_04.rst           | 3 +++
>  doc/guides/rel_notes/release_16_07.rst           | 3 +++
>  doc/guides/rel_notes/release_16_11.rst           | 3 +++
>  doc/guides/rel_notes/release_17_02.rst           | 3 +++
>  doc/guides/rel_notes/release_17_05.rst           | 3 +++
>  doc/guides/rel_notes/release_17_08.rst           | 3 +++
>  doc/guides/rel_notes/release_17_11.rst           | 3 +++
>  doc/guides/rel_notes/release_18_02.rst           | 3 +++
>  doc/guides/rel_notes/release_2_2.rst             | 3 +++

Hi Hemant,

What does it mean to have a license header in release notes?
It looks unnecessary from both license and copyright point of view, is there a
legal requirement for it?

Indeed I was thinking removing the header from the release notes that has it...

Thanks,
ferruh

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Hemant Agrawal]

On 4/9/2018 7:24 PM, Ferruh Yigit wrote:
> On 4/9/2018 2:11 PM, Marko Kovacevic wrote:
>> Added SPDX headers to doc files to have them aligned with
>> the other doc files.
>>
>> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> 
> <...>
> 
>>   doc/guides/rel_notes/release_16_04.rst           | 3 +++
>>   doc/guides/rel_notes/release_16_07.rst           | 3 +++
>>   doc/guides/rel_notes/release_16_11.rst           | 3 +++
>>   doc/guides/rel_notes/release_17_02.rst           | 3 +++
>>   doc/guides/rel_notes/release_17_05.rst           | 3 +++
>>   doc/guides/rel_notes/release_17_08.rst           | 3 +++
>>   doc/guides/rel_notes/release_17_11.rst           | 3 +++
>>   doc/guides/rel_notes/release_18_02.rst           | 3 +++
>>   doc/guides/rel_notes/release_2_2.rst             | 3 +++
> 
> Hi Hemant,
> 
> What does it mean to have a license header in release notes?
> It looks unnecessary from both license and copyright point of view, is there a
> legal requirement for it?
> 
> Indeed I was thinking removing the header from the release notes that has it...

LF legal reported it as missing license. All other *.rst files have the 
license headers.

Let me check it with LF Legal.

Regards,
Hemant

> 
> Thanks,
> ferruh
> 

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Thomas Monjalon]

10/04/2018 06:38, Hemant Agrawal:
> On 4/9/2018 7:24 PM, Ferruh Yigit wrote:
> > On 4/9/2018 2:11 PM, Marko Kovacevic wrote:
> >> Added SPDX headers to doc files to have them aligned with
> >> the other doc files.
> >>
> >> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> > 
> > <...>
> > 
> >>   doc/guides/rel_notes/release_16_04.rst           | 3 +++
> >>   doc/guides/rel_notes/release_16_07.rst           | 3 +++
> >>   doc/guides/rel_notes/release_16_11.rst           | 3 +++
> >>   doc/guides/rel_notes/release_17_02.rst           | 3 +++
> >>   doc/guides/rel_notes/release_17_05.rst           | 3 +++
> >>   doc/guides/rel_notes/release_17_08.rst           | 3 +++
> >>   doc/guides/rel_notes/release_17_11.rst           | 3 +++
> >>   doc/guides/rel_notes/release_18_02.rst           | 3 +++
> >>   doc/guides/rel_notes/release_2_2.rst             | 3 +++
> > 
> > Hi Hemant,
> > 
> > What does it mean to have a license header in release notes?
> > It looks unnecessary from both license and copyright point of view, is there a
> > legal requirement for it?
> > 
> > Indeed I was thinking removing the header from the release notes that has it...
> 
> LF legal reported it as missing license. All other *.rst files have the 
> license headers.
> 
> Let me check it with LF Legal.

It has been recommended to add SPDX tags to release notes,
with a global copyright on behalf of all contributors, or community.

We need a v2 of this patch, thanks.

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Kovacevic, Marko]

> 
> 
> It has been recommended to add SPDX tags to release notes, with a global
> copyright on behalf of all contributors, or community.
> 
> We need a v2 of this patch, thanks.
> 
> 

Hi Thomas,

What exactly is the global copyright ?

Marko K

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Hemant Agrawal]

-----Original Message-----
From: Kovacevic, Marko [mailto:marko.kovacevic@intel.com] 
Sent: Friday, May 25, 2018 9:00 PM
To: Thomas Monjalon <thomas@monjalon.net>; Hemant Agrawal <hemant.agrawal@nxp.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
Subject: RE: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

> 
> 
> It has been recommended to add SPDX tags to release notes, with a 
> global copyright on behalf of all contributors, or community.
> 
> We need a v2 of this patch, thanks.
> 
> 

Hi Thomas,

What exactly is the global copyright ?

[Hemant] We discussed with LF foundation lawyers. It was suggested to use "Copyright 2018 The DPDK Community" 

Regards,
Hemant

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Mcnamara, John]

> -----Original Message-----
> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> Sent: Saturday, May 26, 2018 1:59 PM
> To: Kovacevic, Marko <marko.kovacevic@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files
> 
> 
> -----Original Message-----
> From: Kovacevic, Marko [mailto:marko.kovacevic@intel.com]
> Sent: Friday, May 25, 2018 9:00 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files
> 
> >
> >
> > It has been recommended to add SPDX tags to release notes, with a
> > global copyright on behalf of all contributors, or community.
> >
> > We need a v2 of this patch, thanks.
> >
> >
> 
> Hi Thomas,
> 
> What exactly is the global copyright ?
> 
> [Hemant] We discussed with LF foundation lawyers. It was suggested to use
> "Copyright 2018 The DPDK Community"


Hi Hemant,

Is that valid? "The DPDK Community" isn't a single, clear entity.

If that is what has been agreed then we are okay with it but I wanted to
make 100% sure.

John

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Hemant Agrawal]

HI John,
> 
> -----Original Message-----
> From: Kovacevic, Marko [mailto:marko.kovacevic@intel.com]
> Sent: Friday, May 25, 2018 9:00 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Hemant Agrawal 
> <hemant.agrawal@nxp.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files
> 
> >
> >
> > It has been recommended to add SPDX tags to release notes, with a 
> > global copyright on behalf of all contributors, or community.
> >
> > We need a v2 of this patch, thanks.
> >
> >
> 
> Hi Thomas,
> 
> What exactly is the global copyright ?
> 
> [Hemant] We discussed with LF foundation lawyers. It was suggested to 
> use "Copyright 2018 The DPDK Community"


Hi Hemant,

Is that valid? "The DPDK Community" isn't a single, clear entity.

If that is what has been agreed then we are okay with it but I wanted to make 100% sure.

[Hemant] I got following recommendation from the Linux Foundation legal:
"For files that are e.g. release scripts and documentation, these are typically understood to consist of contributions that are copyrighted by their contributors. So even if there isn't a notice in the file, it would still generally be understood to be subject to its contributors' copyrights and to be licensed out under an open source license.

As you suggested, adding copyright and license notices can help clarify these specifics for downstream uses. We have recommended as best practices that projects add something like "Copyright The _________ Project" or "Copyright The __________ contributors". I think your suggestion of "Copyright The DPDK Community" is fine. And yes, I'd recommend including the appropriate license notice and/or SPDX identifier in these files as well.
Just to be clear, also, we _don't_ recommend removing pre-existing copyright notices unless you are the copyright holder in question. It's generally understood that it's fine to add general copyright notices where accurate, but only the copyright holder should remove or modify their own notices. "

[Hemant] So, "The DPDK Project" or "The DPDK contributors" or "The DPDK community" - anything is fine, we have to use just one of these consistently. 

Regards,
Hemant

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Mcnamara, John]

> -----Original Message-----
> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> Sent: Tuesday, May 29, 2018 4:25 AM
> To: Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Yigit,
> Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files
> 
>...
> 
> [Hemant] I got following recommendation from the Linux Foundation legal:
> "For files that are e.g. release scripts and documentation, these are
> typically understood to consist of contributions that are copyrighted by
> their contributors. So even if there isn't a notice in the file, it would
> still generally be understood to be subject to its contributors'
> copyrights and to be licensed out under an open source license.
> 
> As you suggested, adding copyright and license notices can help clarify
> these specifics for downstream uses. We have recommended as best practices
> that projects add something like "Copyright The _________ Project" or
> "Copyright The __________ contributors". I think your suggestion of
> "Copyright The DPDK Community" is fine. And yes, I'd recommend including
> the appropriate license notice and/or SPDX identifier in these files as
> well.
> Just to be clear, also, we _don't_ recommend removing pre-existing
> copyright notices unless you are the copyright holder in question. It's
> generally understood that it's fine to add general copyright notices where
> accurate, but only the copyright holder should remove or modify their own
> notices. "
> 
> [Hemant] So, "The DPDK Project" or "The DPDK contributors" or "The DPDK
> community" - anything is fine, we have to use just one of these
> consistently.

Hi Hemant,

Thanks for the clarification. In that case I'd suggest we use "The DPDK contributors"
since that is a recognizable entity. 

And if there are no objections, or other recommendations, let's use that for
similar cases in the future.

Marko, can you respin the patchset to include that.

John
-- 

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Kovacevic, Marko]

> > [Hemant] I got following recommendation from the Linux Foundation legal:
> > "For files that are e.g. release scripts and documentation, these are
> > typically understood to consist of contributions that are copyrighted
> > by their contributors. So even if there isn't a notice in the file, it
> > would still generally be understood to be subject to its contributors'
> > copyrights and to be licensed out under an open source license.
> >
> > As you suggested, adding copyright and license notices can help
> > clarify these specifics for downstream uses. We have recommended as
> > best practices that projects add something like "Copyright The
> > _________ Project" or "Copyright The __________ contributors". I think
> > your suggestion of "Copyright The DPDK Community" is fine. And yes,
> > I'd recommend including the appropriate license notice and/or SPDX
> > identifier in these files as well.
> > Just to be clear, also, we _don't_ recommend removing pre-existing
> > copyright notices unless you are the copyright holder in question.
> > It's generally understood that it's fine to add general copyright
> > notices where accurate, but only the copyright holder should remove or
> > modify their own notices. "
> >
> > [Hemant] So, "The DPDK Project" or "The DPDK contributors" or "The
> > DPDK community" - anything is fine, we have to use just one of these
> > consistently.


After some discussion intel would prefer to keep the license as is on the release notes. 
Other contributors/companies can add respective SPDX license for their contributions

Marko K.

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Ferruh Yigit]

On 5/30/2018 4:18 PM, Kovacevic, Marko wrote:
>>> [Hemant] I got following recommendation from the Linux Foundation legal:
>>> "For files that are e.g. release scripts and documentation, these are
>>> typically understood to consist of contributions that are copyrighted
>>> by their contributors. So even if there isn't a notice in the file, it
>>> would still generally be understood to be subject to its contributors'
>>> copyrights and to be licensed out under an open source license.
>>>
>>> As you suggested, adding copyright and license notices can help
>>> clarify these specifics for downstream uses. We have recommended as
>>> best practices that projects add something like "Copyright The
>>> _________ Project" or "Copyright The __________ contributors". I think
>>> your suggestion of "Copyright The DPDK Community" is fine. And yes,
>>> I'd recommend including the appropriate license notice and/or SPDX
>>> identifier in these files as well.
>>> Just to be clear, also, we _don't_ recommend removing pre-existing
>>> copyright notices unless you are the copyright holder in question.
>>> It's generally understood that it's fine to add general copyright
>>> notices where accurate, but only the copyright holder should remove or
>>> modify their own notices. "
>>>
>>> [Hemant] So, "The DPDK Project" or "The DPDK contributors" or "The
>>> DPDK community" - anything is fine, we have to use just one of these
>>> consistently.
> 
> 
> After some discussion intel would prefer to keep the license as is on the release notes. 
> Other contributors/companies can add respective SPDX license for their contributions

Hi Hemant,

Would it matter if keep the Intel copyright in the release notes that already
have it, and add "The DPDK contributors" as a new copyright holder?

And for the ones don't have any copyright, add only "The DPDK contributors".

It is sometimes not easy call to give a go to remove an existing copyright, even
for release notes ...

Thanks,
ferruh

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Hemant Agrawal]

Hi Ferruh,

On 5/30/2018 4:18 PM, Kovacevic, Marko wrote:
>>> [Hemant] I got following recommendation from the Linux Foundation legal:
>>> "For files that are e.g. release scripts and documentation, these 
>>> are typically understood to consist of contributions that are 
>>> copyrighted by their contributors. So even if there isn't a notice 
>>> in the file, it would still generally be understood to be subject to its contributors'
>>> copyrights and to be licensed out under an open source license.
>>>
>>> As you suggested, adding copyright and license notices can help 
>>> clarify these specifics for downstream uses. We have recommended as 
>>> best practices that projects add something like "Copyright The 
>>> _________ Project" or "Copyright The __________ contributors". I 
>>> think your suggestion of "Copyright The DPDK Community" is fine. And 
>>> yes, I'd recommend including the appropriate license notice and/or 
>>> SPDX identifier in these files as well.
>>> Just to be clear, also, we _don't_ recommend removing pre-existing 
>>> copyright notices unless you are the copyright holder in question.
>>> It's generally understood that it's fine to add general copyright 
>>> notices where accurate, but only the copyright holder should remove 
>>> or modify their own notices. "
>>>
>>> [Hemant] So, "The DPDK Project" or "The DPDK contributors" or "The 
>>> DPDK community" - anything is fine, we have to use just one of these 
>>> consistently.
> 
> 
> After some discussion intel would prefer to keep the license as is on the release notes. 
> Other contributors/companies can add respective SPDX license for their 
> contributions

Hi Hemant,

Would it matter if keep the Intel copyright in the release notes that already have it, and add "The DPDK contributors" as a new copyright holder?

And for the ones don't have any copyright, add only "The DPDK contributors".

[Hemant]  agree. There is no need to remove the existing copy rights. However the new files which are generic should have the generic copyright. 

It is sometimes not easy call to give a go to remove an existing copyright, even for release notes ...


Regards,
 Hemant