From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Rosen, Rami" <rami.rosen@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"dev@dpdk.org" <dev@dpdk.org>,
"gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] bus/pci: fix a typo
Date: Thu, 26 Jul 2018 19:25:22 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23F3C1997@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <2190304.KZPNZdMZGo@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, July 26, 2018 8:21 PM
> To: Rosen, Rami <rami.rosen@intel.com>
> Cc: stable@dpdk.org; dev@dpdk.org; gaetan.rivet@6wind.com; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: Re: [dpdk-stable] [PATCH] bus/pci: fix a typo
>
> 26/07/2018 20:31, Rami Rosen:
> > This patch fixes a trivial typo in pci_common.c.
> >
> > Signed-off-by: Rami Rosen <rami.rosen@intel.com>
>
> Fixes: 23eaa9059ec2 ("bus/pci: use given name as generic name")
> Cc: gaetan.rivet@6wind.com
>
> > --- a/drivers/bus/pci/pci_common.c
> > +++ b/drivers/bus/pci/pci_common.c
> > if (devargs != NULL)
> > /* If an rte_devargs exists, the generic rte_device uses the
> > - * given name as its namea
> > + * given name as its name
> > */
>
> You can replace the "a" by a dot.
>
> Applied with above changes, thanks.
Yes. I like to see comments as properly punctuated sentences.
other people have other preferences
prev parent reply other threads:[~2018-07-26 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 18:31 [dpdk-dev] " Rami Rosen
2018-07-26 18:37 ` [dpdk-dev] [dpdk-stable] " Mcnamara, John
2018-07-26 19:20 ` Thomas Monjalon
2018-07-26 19:25 ` Mcnamara, John [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23F3C1997@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=rami.rosen@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).