From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] devtools: check_symbol_change requires bash
Date: Tue, 31 Jul 2018 16:01:19 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23F3C5321@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20180731151416.4868-1-stephen@networkplumber.org>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Tuesday, July 31, 2018 4:14 PM
> To: nhorman@tuxdriver.com
> Cc: dev@dpdk.org; Stephen Hemminger <stephen@networkplumber.org>
> Subject: [dpdk-dev] [PATCH] devtools: check_symbol_change requires bash
>
> The syntax of check_symbol_change uses some bash syntax.
> It does not run correctly on Debian where /bin/sh is not the same as
> /bin/bash.
I think this fix may be required for devtools/checkpatches.sh as well
since it seems to use bash specific call to trap().
I saw this in an internal bug report but didn't have a system to check
the fix on. Could you do a quick check.
John
--
next prev parent reply other threads:[~2018-07-31 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 15:14 Stephen Hemminger
2018-07-31 16:01 ` Mcnamara, John [this message]
2018-07-31 16:31 ` Stephen Hemminger
2018-08-01 16:06 ` Thomas Monjalon
2018-08-05 9:38 ` [dpdk-dev] [PATCH] devtools: fix symbol check for dash Thomas Monjalon
2018-08-09 12:14 ` Ferruh Yigit
2018-08-09 15:14 ` Neil Horman
2018-08-09 16:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23F3C5321@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).