DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] doc: update release notes for 18.11
Date: Mon, 26 Nov 2018 17:58:37 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23F487096@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <16076895.T6Vh9qAcTW@xps>



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, November 26, 2018 2:53 PM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1] doc: update release notes for 18.11
> 
> Hi John,
> 
> Thanks for the update.
> I have a couple of comments below.
>...
> > Huffman Encoding for the Deflate algorithm.
> >
> > +* **Added NXP CAAM JR PMD.**
> > +
> > +  Added the new caam job ring driver for NXP platforms. See the  "NXP
> > + CAAM JOB RING (caam_jr)" document for more details on this new driver.
> > +
> 
> The CAAM JR is a crypto PMD, so I think it should be listed before Huffman
> Encoding, which is a compression PMD.

Ok. Will change.


> We could also use the syntax :doc: to refer to its guide.

I thought so too (and I made a similar change elsewhere) except I couldn't 
find a doc for it in nics. Now that I know it is a cryptodev I know where to
find it. :-) I'll make the change.


> 
> [...]
> > +* ``AVX-512`` support has been disabled for ``GCC`` builds [1]
> > +because of a
> > +  crash [2]. This can affect ``native`` machine type build targets on
> > +the
> > +  platforms that support ``AVX512F`` like ``Intel Skylake``
> > +processors, and
> > +  can cause a possible performance drop. The immediate workaround is
> > +to use
> > +  ``clang`` compiler on these platforms. The issue has been
> > +identified as a
> > +  GCC defect and reported to the GCC community [3]. Further actions
> > +will be
> > +  taken based on the GCC defect result.
> >
> >    [1]: Commit 8d07c82b239f ("mk: disable gcc AVX512F support")
> >    [2]: https://bugs.dpdk.org/show_bug.cgi?id=97
> 
> The references appear on the same line in HTML. Should we make them a list?

I'll fix this as well.

John

  reply	other threads:[~2018-11-26 17:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26 10:51 John McNamara
2018-11-26 10:52 ` Mcnamara, John
2018-11-26 14:53 ` Thomas Monjalon
2018-11-26 17:58   ` Mcnamara, John [this message]
2018-11-26 23:15 ` [dpdk-dev] [PATCH v2] " John McNamara
2018-11-26 23:38   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE23F487096@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=marko.kovacevic@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).