DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Rami Rosen <ramirose@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Trahe, Fiona" <fiona.trahe@intel.com>,
	"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH V3] doc: add guideines for initial PMD submission
Date: Tue, 30 Jul 2019 11:34:35 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE24BCA1CB0@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <3530037.gNTOrFtKmq@xps>



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, May 13, 2019 9:00 PM
> To: Mcnamara, John <john.mcnamara@intel.com>; Rami Rosen
> <ramirose@gmail.com>
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>;
> akhil.goyal@nxp.com; Kovacevic, Marko <marko.kovacevic@intel.com>;
> stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH V3] doc: add guideines for initial PMD
> submission
> 
> 02/05/2019 17:59, Mcnamara, John:
> > From: Rami Rosen [mailto:ramirose@gmail.com]
> > >
> > > This patch for DPDK Contributor's Guidelines indicates the repos
> > > against which a new PMD should be prepared; for example, for new
> > > network ethernet PMDs it should be dpdk-next-net, and for new crypto
> > > PMDs it should be dpdk-next-crypto. For other new PMDs, the
> > > contributor should refer to the MAINTAINERS file. Though this may
> > > seem obvious, it is not mentioned in DPDK documentation.
> > >
> >
> > Acked-by: John McNamara <john.mcnamara@intel.com>
> 
> The MAINTAINERS file is already part of the documentation:
> 	http://doc.dpdk.org/guides/contributing/patches.html#dpdk-
> maintainers
> Should we add a reference to this chapter?

I don't think there is any need to include a link. There are lots of similar
references to the `MAINTAINERS` file in the same doc section.

I think the patch is fine as it is.

John

 


  parent reply	other threads:[~2019-07-30 11:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12 10:26 Rami Rosen
2019-04-12 10:26 ` Rami Rosen
2019-05-02 15:59 ` Mcnamara, John
2019-05-02 15:59   ` Mcnamara, John
2019-05-13 20:00   ` Thomas Monjalon
2019-05-13 20:00     ` Thomas Monjalon
2019-07-30 11:34     ` Mcnamara, John [this message]
2019-08-11  9:34   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE24BCA1CB0@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=ramirose@gmail.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).