From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: allow application to override clean
Date: Thu, 29 Jan 2015 17:07:17 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2EAA330@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <2643675.CbzNhuDmeJ@xps13>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Thursday, January 29, 2015 10:52 AM
> To: stephen@networkplumber.org
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: Re: [dpdk-dev] [PATCH] mk: allow application to override clean
>
> Should we revert your patch? Double-colon rules were avoided in DPDK.
> "Double-colon rules are somewhat obscure and not often very useful"
Hi,
Also, it looks like DPDK applications that had a 'make clean' target, like dpdk-pktgen, now need to change it to a double colon target to avoid a make error like this:
$ cd pktgen-dpdk/
$ make
/tmp/dpdk/mk/rte.app.mk:331: *** target file `clean' has both : and :: entries. Stop.
This is complaining that the local pktgen 'clean:' rule conflicts with the DPDK 'clean::' rule.
John.
--
next prev parent reply other threads:[~2015-01-29 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 6:19 stephen
2015-01-27 11:58 ` Thomas Monjalon
2015-01-28 11:00 ` Olivier MATZ
2015-01-29 10:52 ` Thomas Monjalon
2015-01-29 17:07 ` Mcnamara, John [this message]
[not found] ` <1902752B0C92F943AB7EA9EE13E2DEEC287AE6B39E@HQ1-EXCH02.corp.brocade.com>
[not found] ` <20150129223641.75306372@uryu.home.lan>
2015-01-30 10:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2EAA330@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).