From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 135135A81 for ; Thu, 29 Jan 2015 18:08:49 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 29 Jan 2015 09:08:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,486,1418112000"; d="scan'208";a="644581333" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 29 Jan 2015 09:08:42 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.242]) by IRSMSX102.ger.corp.intel.com ([169.254.2.28]) with mapi id 14.03.0195.001; Thu, 29 Jan 2015 17:07:17 +0000 From: "Mcnamara, John" To: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] mk: allow application to override clean Thread-Index: AQHQOunAfZ3jGuoITUG4qCOdVdDunJzW7WSAgABnCXA= Date: Thu, 29 Jan 2015 17:07:17 +0000 Message-ID: References: <1421993948-24785-1-git-send-email-stephen@networkplumber.org> <54C8C15B.7020407@6wind.com> <2643675.CbzNhuDmeJ@xps13> In-Reply-To: <2643675.CbzNhuDmeJ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mk: allow application to override clean X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 17:08:50 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, January 29, 2015 10:52 AM > To: stephen@networkplumber.org > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH] mk: allow application to override clean >=20 > Should we revert your patch? Double-colon rules were avoided in DPDK. > "Double-colon rules are somewhat obscure and not often very useful" Hi, Also, it looks like DPDK applications that had a 'make clean' target, like = dpdk-pktgen, now need to change it to a double colon target to avoid a make= error like this: $ cd pktgen-dpdk/ $ make /tmp/dpdk/mk/rte.app.mk:331: *** target file `clean' has both : and :: = entries. Stop. This is complaining that the local pktgen 'clean:' rule conflicts with the = DPDK 'clean::' rule. John. --=20