From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9F313B46C for ; Fri, 13 Feb 2015 11:27:37 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 13 Feb 2015 02:27:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,570,1418112000"; d="scan'208";a="527066716" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga003.jf.intel.com with ESMTP; 13 Feb 2015 02:19:18 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.247]) by IRSMSX101.ger.corp.intel.com ([169.254.1.244]) with mapi id 14.03.0195.001; Fri, 13 Feb 2015 10:27:33 +0000 From: "Mcnamara, John" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h Thread-Index: AQHQRdfqTyeQNYPe0Ui6jiAFso/V7pzuQNpQgAAgBYCAAAIYUA== Date: Fri, 13 Feb 2015 10:27:33 +0000 Message-ID: References: <20150213101732.GA13304@bricha3-MOBL3> In-Reply-To: <20150213101732.GA13304@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 10:27:40 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, February 13, 2015 10:18 AM > To: Mcnamara, John > Cc: Stefan Puiu; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h >=20 > > > > > > In C++11 concatenated string literals need to have a space in between= . > > > clang 3.4 reports this as an error (and IIRC also gcc-4.8): > > > > > > dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; > > > C++11 requires a space between literal and identifier > > > [-Wreserved-user-defined- literal] > > > > > > That concatenated string literal with PRI* is used in 65 files in the > DPDK source. Is that the only compilation error that you got? > > > > John >=20 > It should only be a problem in header files. The C files for DPDK source > are always to be compiled up with a C compiler - only the headers get > included in application C++ code. >=20 Hi, In that case it only occurs in 3 header files. I guess that patch should be= extended to include those as well: $ find lib -name \*.h | xargs grep -l '"PRI' lib/librte_vhost/vhost-net-cdev.h lib/librte_eal/common/include/rte_pci.h lib/librte_mempool/rte_mempool.h John. --=20