DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc	-dumpversion' output
Date: Tue, 24 Feb 2015 13:34:44 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2EC7480@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <7529e243896615deb7d93e6080dfd2aced92bf86.1424774816.git.pmatilai@redhat.com>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
> Sent: Tuesday, February 24, 2015 10:47 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -
> dumpversion' output
> 
> Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation on some
> versions of Debian and Ubuntu where gcc has been modified to only emit
> MAJOR.MINOR part of the version from 'gcc -dumpversion'.
> Drop the micro-version from gcc version comparisons to work around this,
> it wasn't being used for anything anyway.
> 
> -ifeq ($(shell test $(GCC_VERSION) -ge 440 && echo 1), 1)
> +ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1)

Hi,

I see this has been applied already but to me this version is less clear than the previous patch version.

And are we sure we won't need the micro-version. If we do, to account for something broken in a point release of gcc, we will have to redo this patch again.

John

  parent reply	other threads:[~2015-02-24 13:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 10:46 Panu Matilainen
2015-02-24 10:59 ` David Marchand
2015-02-24 11:14   ` Olivier MATZ
2015-02-24 11:21     ` Panu Matilainen
2015-02-24 11:32   ` Thomas Monjalon
2015-02-24 13:34 ` Mcnamara, John [this message]
2015-02-24 14:13   ` Panu Matilainen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE2EC7480@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=pmatilai@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).