From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 3CE7D9A8D
 for <dev@dpdk.org>; Tue, 24 Feb 2015 14:34:51 +0100 (CET)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga103.jf.intel.com with ESMTP; 24 Feb 2015 05:29:07 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,638,1418112000"; d="scan'208";a="670794758"
Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3])
 by fmsmga001.fm.intel.com with ESMTP; 24 Feb 2015 05:34:46 -0800
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.247]) by
 IRSMSX108.ger.corp.intel.com ([169.254.11.218]) with mapi id 14.03.0195.001;
 Tue, 24 Feb 2015 13:34:45 +0000
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>
Thread-Topic: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc
 -dumpversion' output
Thread-Index: AQHQUB9QYX5ga1KulUyVURCiBDIcIZz/yzZA
Date: Tue, 24 Feb 2015 13:34:44 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE2EC7480@IRSMSX103.ger.corp.intel.com>
References: <7529e243896615deb7d93e6080dfd2aced92bf86.1424774816.git.pmatilai@redhat.com>
In-Reply-To: <7529e243896615deb7d93e6080dfd2aced92bf86.1424774816.git.pmatilai@redhat.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific
	'gcc	-dumpversion' output
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2015 13:34:51 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
> Sent: Tuesday, February 24, 2015 10:47 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -
> dumpversion' output
>=20
> Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation on some
> versions of Debian and Ubuntu where gcc has been modified to only emit
> MAJOR.MINOR part of the version from 'gcc -dumpversion'.
> Drop the micro-version from gcc version comparisons to work around this,
> it wasn't being used for anything anyway.
>=20
> -ifeq ($(shell test $(GCC_VERSION) -ge 440 && echo 1), 1)
> +ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1)

Hi,

I see this has been applied already but to me this version is less clear th=
an the previous patch version.

And are we sure we won't need the micro-version. If we do, to account for s=
omething broken in a point release of gcc, we will have to redo this patch =
again.

John