From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
Tetsuya Mukawa <mukawa@igel.co.jp>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function
Date: Thu, 26 Feb 2015 15:36:16 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2EC8B34@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2EC8A08@IRSMSX103.ger.corp.intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
> Sent: Thursday, February 26, 2015 12:21 PM
> To: Tetsuya Mukawa; Thomas Monjalon
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port
> hotplug function
>
> The following commit introduced this issue:
>
> $ git bisect good
> c743e50c475f73edf78e5ba26445d7c6ea217f40 is the first bad commit
> commit c743e50c475f73edf78e5ba26445d7c6ea217f40
Hi,
The above commit also has throws a warning with ICC:
lib/librte_pmd_null/rte_eth_null.c(47): error #83:
type qualifier specified more than once
static const char const *valid_arguments[] = {
^
An earlier commit also throws a warning with ICC:
lib/librte_pmd_null/rte_eth_null.c(47): error #83:
type qualifier specified more than once
static const char const *valid_arguments[] = {
^
Commit:
92d94d3744d7760d8d5e490be810612cf4a9cfb0 is the first bad commit
commit 92d94d3744d7760d8d5e490be810612cf4a9cfb0
Author: Tetsuya Mukawa <mukawa@igel.co.jp>
Date: Thu Feb 26 04:32:26 2015 +0900
ethdev: attach or detach port
I applied the following patch to fix these issues, (in order to test with the HEAD). You can review them to see if they are valid and apply something similar:
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index bb94ccb..6ea7a17 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -433,7 +433,7 @@ static enum rte_eth_dev_type
rte_eth_dev_get_device_type(uint8_t port_id)
{
if (!rte_eth_dev_is_valid_port(port_id))
- return -1;
+ return RTE_ETH_DEV_UNKNOWN;
return rte_eth_devices[port_id].dev_type;
}
diff --git a/lib/librte_pmd_null/rte_eth_null.c b/lib/librte_pmd_null/rte_eth_null.c
index bb10276..3ef5842 100644
--- a/lib/librte_pmd_null/rte_eth_null.c
+++ b/lib/librte_pmd_null/rte_eth_null.c
@@ -44,7 +44,7 @@
static unsigned default_packet_size = 64;
static unsigned default_packet_copy;
-static const char const *valid_arguments[] = {
+static const char *valid_arguments[] = {
ETH_NULL_PACKET_SIZE_ARG,
ETH_NULL_PACKET_COPY_ARG,
NULL
John.
--
next prev parent reply other threads:[~2015-02-26 15:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mukawa@igel.co.jp>
2014-10-01 4:57 ` [dpdk-dev] [PATCH v2] PMD for performance measurement mukawa
2014-10-01 4:57 ` [dpdk-dev] [PATCH v2] librte_pmd_null: Add null PMD mukawa
2014-11-13 12:17 ` Thomas Monjalon
2014-12-16 8:39 ` [dpdk-dev] [PATCH v3] " Tetsuya Mukawa
2014-12-16 8:44 ` Tetsuya Mukawa
2014-12-16 8:47 ` Thomas Monjalon
2014-12-16 8:49 ` Tetsuya Mukawa
2015-01-20 3:00 ` [dpdk-dev] [PATCH v4 1/2] " Tetsuya Mukawa
2015-01-20 3:00 ` [dpdk-dev] [PATCH v4 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-06 4:38 ` [dpdk-dev] [PATCH v6 1/2] librte_pmd_null: Add null PMD Tetsuya Mukawa
2015-02-06 4:38 ` [dpdk-dev] [PATCH v6 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-06 11:37 ` Iremonger, Bernard
2015-02-06 11:32 ` [dpdk-dev] [PATCH v6 1/2] librte_pmd_null: Add null PMD Iremonger, Bernard
2015-02-09 8:54 ` Tetsuya Mukawa
2015-02-12 2:44 ` [dpdk-dev] [PATCH v7 1/2] librte_pmd_null: Add Null PMD Tetsuya Mukawa
2015-02-12 2:44 ` [dpdk-dev] [PATCH v7 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-16 4:19 ` [dpdk-dev] [PATCH v8 1/2] librte_pmd_null: Add Null PMD Tetsuya Mukawa
2015-02-16 4:19 ` [dpdk-dev] [PATCH v8 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-16 16:38 ` Iremonger, Bernard
2015-02-16 16:38 ` [dpdk-dev] [PATCH v8 1/2] librte_pmd_null: Add Null PMD Iremonger, Bernard
2015-02-19 10:41 ` [dpdk-dev] [PATCH v9 " Tetsuya Mukawa
2015-02-19 10:41 ` [dpdk-dev] [PATCH v9 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-20 6:41 ` [dpdk-dev] [PATCH v10 1/2] librte_pmd_null: Add Null PMD Tetsuya Mukawa
2015-02-20 6:41 ` [dpdk-dev] [PATCH v10 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-23 5:12 ` [dpdk-dev] [PATCH v11 1/2] librte_pmd_null: Add Null PMD Tetsuya Mukawa
2015-02-23 5:12 ` [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function Tetsuya Mukawa
2015-02-25 23:35 ` Thomas Monjalon
2015-02-26 0:49 ` Stephen Hemminger
2015-02-26 7:03 ` Thomas Monjalon
2015-02-26 9:06 ` Tetsuya Mukawa
2015-02-26 10:57 ` Thomas Monjalon
2015-02-26 11:50 ` Tetsuya Mukawa
2015-03-04 3:37 ` Tetsuya Mukawa
2015-02-26 12:21 ` Mcnamara, John
2015-02-26 15:36 ` Mcnamara, John [this message]
2015-02-27 1:31 ` Tetsuya Mukawa
2015-02-27 23:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2EC8B34@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=mukawa@igel.co.jp \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).