From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B26B35A76 for ; Mon, 9 Mar 2015 14:39:07 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 09 Mar 2015 06:39:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,367,1422950400"; d="scan'208";a="695942987" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga002.jf.intel.com with ESMTP; 09 Mar 2015 06:39:05 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.247]) by IRSMSX107.ger.corp.intel.com ([169.254.10.35]) with mapi id 14.03.0195.001; Mon, 9 Mar 2015 13:39:05 +0000 From: "Mcnamara, John" To: Vlad Zolotarov , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback initialization Thread-Index: AQHQWlG5eyG6G/Bnk02U+rO3rMrbtp0UJcNA Date: Mon, 9 Mar 2015 13:39:04 +0000 Message-ID: References: <1425895968-8597-1-git-send-email-vladz@cloudius-systems.com> <1425895968-8597-4-git-send-email-vladz@cloudius-systems.com> In-Reply-To: <1425895968-8597-4-git-send-email-vladz@cloudius-systems.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 13:39:08 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Monday, March 9, 2015 10:13 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback > initialization >=20 > @@ -3641,23 +3676,17 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev) > buf_size =3D (uint16_t) ((srrctl & IXGBE_SRRCTL_BSIZEPKT_MASK) > << > IXGBE_SRRCTL_BSIZEPKT_SHIFT); >=20 > - if (dev->data->dev_conf.rxmode.enable_scatter || > - /* It adds dual VLAN length for supporting dual VLAN */ > - (dev->data->dev_conf.rxmode.max_rx_pkt_len + > - 2 * IXGBE_VLAN_TAG_SIZE) > buf_size){ > - if (!dev->data->scattered_rx) > - PMD_INIT_LOG(DEBUG, "forcing scatter mode"); > + /* It adds dual VLAN length for supporting dual VLAN */ > + if (dev->data->dev_conf.rxmode.max_rx_pkt_len + > + 2 * IXGBE_VLAN_TAG_SIZE > buf_size) > dev->data->scattered_rx =3D 1; > -#ifdef RTE_IXGBE_INC_VECTOR > - if (rte_is_power_of_2(rxq->nb_rx_desc)) > - dev->rx_pkt_burst =3D > - ixgbe_recv_scattered_pkts_vec; > - else > -#endif > - dev->rx_pkt_burst =3D ixgbe_recv_scattered_pkts; > - } > } >=20 > + if (rx_conf->enable_scatter) > + dev->data->scattered_rx =3D 1; Hi, There is a compilation issue here when this patch is applied to the current= master (with previous 2 patches applied as well): make T=3Dx86_64-native-linuxapp-gcc install CC=3Dgcc ... =3D=3D Build lib/librte_pmd_ixgbe CC ixgbe_rxtx.o /home/user/dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function 'ixgbe_dev_r= x_init': /home/user/dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx.c:3689:6: error: 'rx_conf' = undeclared (first use in this function) /home/user/dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx.c:3689:6: note: each undecl= ared identifier is reported only once for each function it appears in make[5]: *** [ixgbe_rxtx.o] Error 1 This is using the default DPDK linuxapp config. John