From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: additional parameter in RX callback
Date: Thu, 12 Mar 2015 23:24:37 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2ECE45C@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20150312191540.GB15260@hmsreliant.think-freely.org>
> -----Original Message-----
> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Thursday, March 12, 2015 7:16 PM
> To: Mcnamara, John
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ethdev: additional parameter in RX
> callback
>
>
> Well, we're well past the new feature phase of this cycle, so I would say
> NACK.
Hi Neil,
This is more of a bug fix than a feature request.
In retrospect it was a mistake not to have the same function declaration in the callbacks as in the rte_eth_XX_burst functions since it was likely that the callbacks would need access to the same information.
This patch is trying to fix that error before it is set in stone.
John
next prev parent reply other threads:[~2015-03-12 23:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 16:54 John McNamara
2015-03-12 16:54 ` [dpdk-dev] [PATCH] ethdev: added additional packet count parameter to RX callbacks John McNamara
2015-03-12 19:15 ` [dpdk-dev] [PATCH] ethdev: additional parameter in RX callback Neil Horman
2015-03-12 23:24 ` Mcnamara, John [this message]
2015-03-13 9:41 ` Bruce Richardson
2015-03-13 13:45 ` Neil Horman
2015-03-13 14:50 ` Bruce Richardson
2015-03-13 15:09 ` Neil Horman
2015-03-13 16:26 ` Mcnamara, John
2015-03-13 17:31 ` Neil Horman
2015-03-13 18:28 ` Mcnamara, John
2015-03-13 23:15 ` Neil Horman
2015-03-23 15:16 ` Thomas Monjalon
2015-03-23 15:29 ` Bruce Richardson
2015-03-23 16:00 ` Neil Horman
2015-03-30 19:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2ECE45C@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).