From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4867BC5D2 for ; Tue, 28 Apr 2015 16:00:46 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 28 Apr 2015 07:00:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,664,1422950400"; d="scan'208";a="702126391" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga001.fm.intel.com with ESMTP; 28 Apr 2015 07:00:40 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.76]) by IRSMSX108.ger.corp.intel.com ([169.254.11.246]) with mapi id 14.03.0224.002; Tue, 28 Apr 2015 15:00:38 +0100 From: "Mcnamara, John" To: Tero Aho , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 3/3] pcap: add byte and error counters into statistics Thread-Index: AQHQUpPIo5fCvNlKW0Gmh/UrkWqrD51i0JYQ Date: Tue, 28 Apr 2015 14:00:38 +0000 Message-ID: References: <1425044560-23397-1-git-send-email-tero.aho@coriant.com> <1425044560-23397-4-git-send-email-tero.aho@coriant.com> In-Reply-To: <1425044560-23397-4-git-send-email-tero.aho@coriant.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] pcap: add byte and error counters into statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2015 14:00:46 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tero Aho > Sent: Friday, February 27, 2015 1:43 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 3/3] pcap: add byte and error counters into > statistics >=20 > Added input/ouput byte counters into pcap interface statistics, also call= s > pcap_stats to add dropped packets into input errors. >=20 > Signed-off-by: Tero Aho > --- > lib/librte_pmd_pcap/rte_eth_pcap.c | 37 +++++++++++++++++++++++++++++---= - > ---- > 1 file changed, 29 insertions(+), 8 deletions(-) >=20 > diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c > b/lib/librte_pmd_pcap/rte_eth_pcap.c > index 3f23f0a..1c472ac 100644 > --- a/lib/librte_pmd_pcap/rte_eth_pcap.c > +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c > @@ -71,6 +71,7 @@ struct pcap_rx_queue { > uint8_t in_port; > struct rte_mempool *mb_pool; > volatile unsigned long rx_pkts; > + volatile unsigned long rx_octs; Hi Tero, The equivalent rx/tx_octs members in rte_eth_stats are called ibytes/obytes= so these variables should be called rx_bytes/tx_bytes for consistency. Also, not really your issue, but do these members actually need to be volat= ile for pcap? Otherwise looks okay. John. --=20