DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] GitHub sandbox for the DPDK community
Date: Wed, 6 May 2015 10:11:42 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2F1A2AC@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <D1690998.1E825%keith.wiles@intel.com>

Hi,

It is always difficult to sell change unless there is a majority
in favour of it. If the project was already on GitHub and someone
was proposing to move to a ML/Patch workflow then we would
probably see as much resistance.

Here are some advantages and disadvantage of GitHub from personal
experience of working with projects that were exclusively hosted
there.

Some advantages of GitHub:

* Integrated bug tracker with #num linking of commits to issues
  and issues to commits.

* Inline code reviews of pull requests (PR)s.

* Patches can be viewed in the context of the surrounding code.

* Ability to tag issues/PRs with tags like "Bug", "Documentation"
  and to add them to milestones. This give a project level view
  of the current state of issues/PRs.

* Easy integration and automatic updating with third party tools
  like ReadTheDocs, TravisCI and Coverity. This makes it very
  easy to setup a continuous integration environment.

Personally, I find the third party tool integration the most
compelling feature. It allows you to configure the tools to work
with updates to the repo rather than configuring the repo (via
hooks) to work with the tools. The issue tracker integration is
also very useful.

These features aren't exclusive to GitHub and we could probably
replicate the useful ones into our current workflow (issue
tracking in particular is missing). The advantage that GitHub has
is that these features are already there and fully integrated.

Some disadvantages of using GitHub:

* Issue/PR discussions aren't threaded and in long discussions it
  can be a little unclear who is replying to whom/what.

* If there are a lot of forks with PRs the network tree becomes
  too big and GitHub doesn't display it.

* The fork/PR workflow with rebasing, squashing and "push
  --force" on branches is probably a significant change to most
  people's workflow.

John.
-- 

  parent reply	other threads:[~2015-05-06 10:11 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01 15:56 Wiles, Keith
2015-05-01 16:45 ` Neil Horman
2015-05-01 17:18   ` Aaro Koskinen
2015-05-04 12:39     ` Qiu, Michael
2015-05-01 17:31   ` Matthew Hall
2015-05-01 17:45     ` Wiles, Keith
2015-05-01 18:48     ` Neil Horman
2015-05-01 19:10       ` Wiles, Keith
2015-05-02  2:59         ` Wiles, Keith
2015-05-03 21:00         ` Neil Horman
2015-05-04  3:51           ` Wiles, Keith
2015-05-04 12:43     ` Qiu, Michael
2015-05-04 17:48       ` Matthew Hall
2015-05-04 18:52         ` Neil Horman
2015-05-05  3:12         ` Wiles, Keith
2015-05-05  3:25           ` Jim Thompson
2015-05-05 13:55             ` Neil Horman
2015-05-05 16:43               ` Wiles, Keith
2015-05-05 17:57                 ` John W. Linville
2015-05-05 18:30                   ` Wiles, Keith
2015-05-05 18:46                     ` John W. Linville
2015-05-05 19:07                 ` Neil Horman
2015-05-05 20:15                   ` Wiles, Keith
2015-05-06  8:12                 ` Panu Matilainen
2015-05-06  8:30                   ` Simon Kågström
2015-05-06  9:00                     ` Panu Matilainen
2015-05-06 10:37                     ` Neil Horman
2015-05-07 15:26                   ` John W. Linville
2015-05-01 18:01   ` Wiles, Keith
2015-05-01 18:09 ` Stephen Hemminger
2015-05-01 18:17   ` Wiles, Keith
2015-05-04 20:34     ` Marc Sune
2015-05-05  2:54       ` Wiles, Keith
2015-05-01 19:49   ` Matthew Hall
2015-05-01 19:59     ` Aaro Koskinen
2015-05-01 20:36       ` Matthew Hall
2015-05-02 11:40         ` Neil Horman
2015-05-02 12:37           ` Thomas F Herbert
2015-05-02 14:07             ` Wiles, Keith
2015-05-02 13:59           ` Wiles, Keith
2015-05-04 21:08             ` Marc Sune
2015-05-05  3:09               ` Wiles, Keith
2015-05-04  6:52 ` Simon
2015-05-04  9:05   ` Marc Sune
2015-05-06 10:11 ` Mcnamara, John [this message]
2015-05-06 21:09 ` Thomas Monjalon
2015-05-06 21:37   ` Marc Sune
2015-05-06 23:49     ` Wiles, Keith
2015-05-07  3:37       ` Wiles, Keith
2015-05-12 14:38         ` Thomas Monjalon
2015-05-04  5:08 Wiles, Keith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE2F1A2AC@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).