Re: [dpdk-dev] [PATCH v3 0/9] Chelsio Terminator 5 (T5) 10G/40G Poll Mode Driver

["Mcnamara, John" <john.mcnamara@intel.com>]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rahul Lakkireddy
> Sent: Thursday, June 18, 2015 1:17 PM
> To: dev@dpdk.org
> Cc: Felix Marti; Kumar Sanghvi; Nirranjan Kirubaharan
> Subject: [dpdk-dev] [PATCH v3 0/9] Chelsio Terminator 5 (T5) 10G/40G Poll
> Mode Driver
> 
> ...
> Rahul Lakkireddy (9):
>   cxgbe: add hardware specific api for all supported Chelsio T5 series
>     adapters.
>   cxgbe: add cxgbe poll mode driver.
>   cxgbe: add device configuration and RX support for cxgbe PMD.
>   cxgbe: add TX support for cxgbe PMD.
>   cxgbe: add device related operations for cxgbe PMD.
>   cxgbe: add port statistics for cxgbe PMD.
>   cxgbe: add link related functions for cxgbe PMD.
>   cxgbe: add flow control functions for cxgbe PMD.
>   doc: add cxgbe PMD documentation under doc/guides/nics/cxgbe.rst
> 
>  MAINTAINERS                                 |    5 +
>  config/common_linuxapp                      |   10 +
>  doc/guides/nics/cxgbe.rst                   |  209 +++
>  doc/guides/nics/index.rst                   |    1 +
>  doc/guides/prog_guide/source_org.rst        |    1 +
>  drivers/net/Makefile                        |    1 +
>  drivers/net/cxgbe/Makefile                  |   78 +
>  drivers/net/cxgbe/base/adapter.h            |  565 ++++++
>  drivers/net/cxgbe/base/common.h             |  401 ++++
>  drivers/net/cxgbe/base/t4_chip_type.h       |   79 +
>  drivers/net/cxgbe/base/t4_hw.c              | 2686 +++++++++++++++++++++++++++
>  drivers/net/cxgbe/base/t4_hw.h              |  149 ++
>  drivers/net/cxgbe/base/t4_msg.h             |  345 ++++
>  drivers/net/cxgbe/base/t4_pci_id_tbl.h      |  148 ++
>  drivers/net/cxgbe/base/t4_regs.h            |  779 ++++++++
>  drivers/net/cxgbe/base/t4_regs_values.h     |  168 ++
>  drivers/net/cxgbe/base/t4fw_interface.h     | 1730 +++++++++++++++++
>  drivers/net/cxgbe/cxgbe.h                   |   60 +
>  drivers/net/cxgbe/cxgbe_compat.h            |  266 +++
>  drivers/net/cxgbe/cxgbe_ethdev.c            |  802 ++++++++
>  drivers/net/cxgbe/cxgbe_main.c              | 1207 ++++++++++++
>  drivers/net/cxgbe/rte_pmd_cxgbe_version.map |    4 +
>  drivers/net/cxgbe/sge.c                     | 2253 ++++++++++++++++++++++
>  mk/rte.app.mk                               |    1 +

Hi,

Some minor feedback to help the patchset on its way.

The patches apply cleanly and compile. There is an compilation initialization warning after patch 2/9 but that is fixed in 3/9. Checkpatch warnings are all minor. Documentation is good. All changes are isolated to drivers/net/cxgbe.

John