From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 209D6C68A for ; Thu, 18 Jun 2015 15:44:31 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 18 Jun 2015 06:44:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,638,1427785200"; d="scan'208";a="590252925" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga003.jf.intel.com with ESMTP; 18 Jun 2015 06:44:29 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.216]) by IRSMSX153.ger.corp.intel.com ([169.254.9.140]) with mapi id 14.03.0224.002; Thu, 18 Jun 2015 14:44:22 +0100 From: "Mcnamara, John" To: Rahul Lakkireddy , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 0/9] Chelsio Terminator 5 (T5) 10G/40G Poll Mode Driver Thread-Index: AQHQqcED75hHc5zLtU+nlijyZTyS4p2yRC0g Date: Thu, 18 Jun 2015 13:44:21 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: Kumar Sanghvi , Felix Marti , Nirranjan Kirubaharan Subject: Re: [dpdk-dev] [PATCH v3 0/9] Chelsio Terminator 5 (T5) 10G/40G Poll Mode Driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 13:44:32 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rahul Lakkireddy > Sent: Thursday, June 18, 2015 1:17 PM > To: dev@dpdk.org > Cc: Felix Marti; Kumar Sanghvi; Nirranjan Kirubaharan > Subject: [dpdk-dev] [PATCH v3 0/9] Chelsio Terminator 5 (T5) 10G/40G Poll > Mode Driver >=20 > ... > Rahul Lakkireddy (9): > cxgbe: add hardware specific api for all supported Chelsio T5 series > adapters. > cxgbe: add cxgbe poll mode driver. > cxgbe: add device configuration and RX support for cxgbe PMD. > cxgbe: add TX support for cxgbe PMD. > cxgbe: add device related operations for cxgbe PMD. > cxgbe: add port statistics for cxgbe PMD. > cxgbe: add link related functions for cxgbe PMD. > cxgbe: add flow control functions for cxgbe PMD. > doc: add cxgbe PMD documentation under doc/guides/nics/cxgbe.rst >=20 > MAINTAINERS | 5 + > config/common_linuxapp | 10 + > doc/guides/nics/cxgbe.rst | 209 +++ > doc/guides/nics/index.rst | 1 + > doc/guides/prog_guide/source_org.rst | 1 + > drivers/net/Makefile | 1 + > drivers/net/cxgbe/Makefile | 78 + > drivers/net/cxgbe/base/adapter.h | 565 ++++++ > drivers/net/cxgbe/base/common.h | 401 ++++ > drivers/net/cxgbe/base/t4_chip_type.h | 79 + > drivers/net/cxgbe/base/t4_hw.c | 2686 +++++++++++++++++++++= ++++++ > drivers/net/cxgbe/base/t4_hw.h | 149 ++ > drivers/net/cxgbe/base/t4_msg.h | 345 ++++ > drivers/net/cxgbe/base/t4_pci_id_tbl.h | 148 ++ > drivers/net/cxgbe/base/t4_regs.h | 779 ++++++++ > drivers/net/cxgbe/base/t4_regs_values.h | 168 ++ > drivers/net/cxgbe/base/t4fw_interface.h | 1730 +++++++++++++++++ > drivers/net/cxgbe/cxgbe.h | 60 + > drivers/net/cxgbe/cxgbe_compat.h | 266 +++ > drivers/net/cxgbe/cxgbe_ethdev.c | 802 ++++++++ > drivers/net/cxgbe/cxgbe_main.c | 1207 ++++++++++++ > drivers/net/cxgbe/rte_pmd_cxgbe_version.map | 4 + > drivers/net/cxgbe/sge.c | 2253 +++++++++++++++++++++= + > mk/rte.app.mk | 1 + Hi, Some minor feedback to help the patchset on its way. The patches apply cleanly and compile. There is an compilation initializati= on warning after patch 2/9 but that is fixed in 3/9. Checkpatch warnings ar= e all minor. Documentation is good. All changes are isolated to drivers/net= /cxgbe. John