From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 10AF5C876
 for <dev@dpdk.org>; Fri, 19 Jun 2015 18:33:39 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga101.fm.intel.com with ESMTP; 19 Jun 2015 09:33:38 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,644,1427785200"; d="scan'208";a="730755817"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by fmsmga001.fm.intel.com with ESMTP; 19 Jun 2015 09:33:38 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.216]) by
 IRSMSX153.ger.corp.intel.com ([169.254.9.140]) with mapi id 14.03.0224.002;
 Fri, 19 Jun 2015 17:33:37 +0100
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Vladimir Medvedkin <medvedkinv@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v4] Add toeplitz hash algorithm used by RSS
Thread-Index: AQHQqqBxItVHklYe4kSd/lyotG4/hZ2z69uAgAAZlsA=
Date: Fri, 19 Jun 2015 16:33:37 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE2F4875F@IRSMSX103.ger.corp.intel.com>
References: <1431097092-19790-1-git-send-email-medvedkinv@gmail.com>
 <1434725752-22847-1-git-send-email-medvedkinv@gmail.com>
 <59AF69C657FD0841A61C55336867B5B03455A83A@IRSMSX103.ger.corp.intel.com>
In-Reply-To: <59AF69C657FD0841A61C55336867B5B03455A83A@IRSMSX103.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4] Add toeplitz hash algorithm used by RSS
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Jun 2015 16:33:40 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Richardson, Bruce
> Sent: Friday, June 19, 2015 5:00 PM
> To: Vladimir Medvedkin; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] Add toeplitz hash algorithm used by RS=
S
>=20
> Missing signoff line.
>=20

Hi,

It would also be worth running Linux checkpatch against the patch, which wo=
uld have caught the missing signoff. It also shows a lot of warnings in the=
 patch which indicates conflicts with the coding guidelines.

John=20