From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by dpdk.org (Postfix) with ESMTP id E34502A5E
for <dev@dpdk.org>; Wed, 8 Jul 2015 12:31:19 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by orsmga101.jf.intel.com with ESMTP; 08 Jul 2015 03:31:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,431,1432623600"; d="scan'208";a="760506044"
Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99])
by orsmga002.jf.intel.com with ESMTP; 08 Jul 2015 03:31:18 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.216]) by
IRSMSX107.ger.corp.intel.com ([169.254.10.39]) with mapi id 14.03.0224.002;
Wed, 8 Jul 2015 11:31:16 +0100
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Wu, Jingjing"
<jingjing.wu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf
Thread-Index: AQHQr95ThxLBcEpw80GFhSMs0EGyRJ3QGC8AgAFXiEA=
Date: Wed, 8 Jul 2015 10:31:15 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE2F67DE9@IRSMSX103.ger.corp.intel.com>
References: <1433492166-30758-1-git-send-email-jingjing.wu@intel.com>
<1433917473-21508-2-git-send-email-jingjing.wu@intel.com>
<9BB6961774997848B5B42BEC655768F8C59FF9@SHSMSX104.ccr.corp.intel.com>
<2821398.avzWtSOKrm@xps13>
In-Reply-To: <2821398.avzWtSOKrm@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev:
rename rte_eth_vmdq_mirror_conf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2015 10:31:20 -0000
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, July 7, 2015 3:51 PM
> To: Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: rename
> rte_eth_vmdq_mirror_conf
>=20
> > Additional, about the validate-abi.sh, does it mean we need to fix all
> > the problems it reports? Or we can decide case by case.
> > Can a Low Severity problem be acceptable?
>=20
> We have to decide case by case.
> It makes ABI checking impossible to automate.
> That's why any help is welcome to check the git HEAD for ABI violation.
Hi,
Automated testing for ABI breaks is tricky since it requires some interpret=
ation of the errors and the severity level.
However, each report file contains a 2 line summary at the top that can be =
read and parsed. For example (with long lines wrapped):
head -2 compat_reports/librte_mbuf.so/v2.0.0_to_ABI_CHECK/compat_report=
.html
<!-- kind:binary;verdict:compatible;affected:0;added:1;removed:0;
type_problems_high:0;type_problems_medium:0;type_problems_low:0;
interface_problems_high:0;interface_problems_medium:0;
interface_problems_low:0;changed_constants:0;tool_version:1.99.8.5=
-->
<!-- kind:source;verdict:compatible;affected:0;added:1;removed:0;
type_problems_high:0;type_problems_medium:0;type_problems_low:0;
interface_problems_high:0;interface_problems_medium:0;
interface_problems_low:0;changed_constants:0;tool_version:1.99.8.5=
-->
This still requires interpretation but it can be used to search for categor=
ies of incompatibility.
To test if a patchset breaks the API it is possible to do something like th=
e following. Say, for example that you have committed 3 commits to your loc=
al master, you could tag and run the checker like this:
git checkout master
git tag -f ABI_CHECK_AFTER
git tag -f ABI_CHECK_BEFORE HEAD~3
./scripts/validate-abi.sh ABI_CHECK_BEFORE ABI_CHECK_AFTER x86_64-nativ=
e-linuxapp-gcc
grep -lr "kind:binary;verdict:incompatible" compat_reports/
The grep could be extended to match other categories that you are intereste=
d in. However, it is still probably better to examine the reports manually.
You can also use something this to run a git bisect to find a commit that i=
ntroduced an ABI incompatibility:
# Tag the head and some known good point in the history.
git checkout master
git tag -f ABI_CHECK_END
git tag -f ABI_CHECK_START v2.0.0
# Start git bisect with bad and good.
git bisect start ABI_CHECK_END ABI_CHECK_START
# Run bisect with a script.
git bisect run ~/abi_bisect.sh
Where the ~/abi_bisect.sh script that searches for ABI incompatibilities lo=
oks like this:
#!/bin/sh
git tag -f ABI_CHECK_END
rm -rf compat_reports/
./scripts/validate-abi.sh ABI_CHECK_START ABI_CHECK_END x86_64-native-l=
inuxapp-gcc
! grep -lr "kind:binary;verdict:incompatible" compat_reports/
John.
--=20