From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CE2385A72 for ; Wed, 8 Jul 2015 18:11:52 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 08 Jul 2015 09:11:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,432,1432623600"; d="scan'208";a="758449579" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga002.fm.intel.com with ESMTP; 08 Jul 2015 09:11:51 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.216]) by IRSMSX154.ger.corp.intel.com ([169.254.12.91]) with mapi id 14.03.0224.002; Wed, 8 Jul 2015 17:11:50 +0100 From: "Mcnamara, John" To: Klaus Degner , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] add rx and tx byte counter statistics for PCAP PMD Thread-Index: AQHQsymGcA1M38Ch10ix4IVGxYm4N53Ryw4Q Date: Wed, 8 Jul 2015 16:11:50 +0000 Message-ID: References: <1435664375-25648-1-git-send-email-kd@allegro-packets.com> In-Reply-To: <1435664375-25648-1-git-send-email-kd@allegro-packets.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] add rx and tx byte counter statistics for PCAP PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 16:11:53 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Klaus Degner > Sent: Tuesday, June 30, 2015 12:40 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] add rx and tx byte counter statistics for=20 > PCAP PMD >=20 > PCAP PMD vdev accounts only rx and tx packet statistics. > This patch adds support for rx and tx bytes statistics. Hi, Thanks for that.=20 Just a few minor comments. The subject line should contain the library/module being updated and the bo= dy is repeats, more or less, the same comment twice. Do a git log on the fi= le to see the standard format. > unsigned i; > - unsigned long rx_total =3D 0, tx_total =3D 0, tx_err_total =3D 0; > + unsigned long rx_total =3D 0, tx_total =3D 0, tx_err_total =3D 0,=20 > +rx_b_total =3D 0, tx_b_total =3D 0; This line exceeds the 80 character limit. Maybe separate the rx and tx init= ialisations onto separate lines. Or else put them all on separate lines in = line with the Coding Guidelines: http://dpdk.readthedocs.org/en/latest/guidelines/coding_style.html#local= -variables Run checkpatch on the patch before submission to pick up any issues like th= is. If you make those changes and resubmit as a V2 I'll ack it. John. --=20