From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id ACA73C3BA for ; Fri, 10 Jul 2015 18:08:25 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 10 Jul 2015 09:08:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,447,1432623600"; d="scan'208";a="522088770" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 10 Jul 2015 09:08:04 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.216]) by IRSMSX152.ger.corp.intel.com ([169.254.6.90]) with mapi id 14.03.0224.002; Fri, 10 Jul 2015 17:07:53 +0100 From: "Mcnamara, John" To: Neil Horman , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] mk: enable next abi in static libs Thread-Index: AQHQtRN+bNpo8qlpMUCqwHNlLhtT053OYa6AgAAEuACAAAPwAIAATDkAgAA4iYCAAOI6gIAAGY0AgAAQL4CABO66QA== Date: Fri, 10 Jul 2015 16:07:53 +0000 Message-ID: References: <1435874746-32095-1-git-send-email-thomas.monjalon@6wind.com> <33405606.8BIq3zMLWK@xps13> <20150707111441.GA6932@hmsreliant.think-freely.org> <2767225.WkjHcd5aCI@xps13> <20150707134403.GC6932@hmsreliant.think-freely.org> In-Reply-To: <20150707134403.GC6932@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] mk: enable next abi in static libs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 16:08:26 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Neil Horman > Sent: Tuesday, July 7, 2015 2:44 PM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mk: enable next abi in static libs >=20 > On Tue, Jul 07, 2015 at 05:46:08AM -0700, Thomas Monjalon wrote: > > Neil, in the meantime, could you please help to check ABI breakage in > the HEAD? > > > Took a look, the only ABI break I see that we need to worry about is the > one introduced in commit 8eecb3295aed0a979def52245564d03be172a83c. It add= s > a bitfield called lro into the existing uint8_t there, but does so in the > middle of the set, which pushes the other bits around, breaking ABI. It > should have been added to the end. Hi, Is it okay to submit a patch to move it to the end? John. --=20