Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code

["Mcnamara, John" <john.mcnamara@intel.com>]

> -----Original Message-----
> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Monday, July 13, 2015 3:00 PM
> To: Mcnamara, John
> Cc: dev@dpdk.org; vladz@cloudius-systems.com
> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
> 
> > > > -		dev_started : 1;   /**< Device state: STARTED(1) / STOPPED(0). */
> > > > +		dev_started : 1,   /**< Device state: STARTED(1) / STOPPED(0). */
> > > > +		lro         : 1;   /**< RX LRO is ON(1) / OFF(0) */
> > > >
> > > >
> >
> Thank you, I'll ack as soon as Chao confirms its not a problem on ppc Neil

Hi,

Just pinging Chao Zhu on this again so that it isn't forgotten.

Neil, just to be clear, are you looking for a validate-abi.sh check on PPC?

Just for context, the lro flag doesn't seem to be used anywhere that would be affected by endianness:

    $ ag -w "\->lro"             
    drivers/net/ixgbe/ixgbe_rxtx.c
    3767:   if (dev->data->lro) {
    3967:   dev->data->lro = 1;

    drivers/net/ixgbe/ixgbe_ethdev.c
    1689:   dev->data->lro = 0;

John.
--