From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (unknown [45.249.212.255]) by dpdk.org (Postfix) with ESMTP id 5E5455F5F for ; Wed, 21 Mar 2018 05:59:00 +0100 (CET) Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.53]) by Forcepoint Email with ESMTP id A1AA0F1F9D505; Wed, 21 Mar 2018 12:58:55 +0800 (CST) Received: from DGGEMM505-MBS.china.huawei.com ([169.254.2.114]) by DGGEMM403-HUB.china.huawei.com ([10.3.20.211]) with mapi id 14.03.0361.001; Wed, 21 Mar 2018 12:58:46 +0800 From: "Zhoujian (jay)" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" , "thomas@monjalon.net" , "Gonglei (Arei)" , "Zeng, Xin" , "Huangweidong (C)" , "wangxin (U)" , longpeng Thread-Topic: [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices Thread-Index: AQHTrXGIbROEtz3+3EKopET2j5i6raPZs6SAgACQ2RA= Date: Wed, 21 Mar 2018 04:58:46 +0000 Message-ID: References: <02e4c16f6c0f330f8c7941160a69e8d20510713f.1519477564.git.jianjay.zhou@huawei.com> <9F7182E3F746AB4EA17801C148F3C604331024B8@IRSMSX101.ger.corp.intel.com> In-Reply-To: <9F7182E3F746AB4EA17801C148F3C604331024B8@IRSMSX101.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.19.14] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 04:59:00 -0000 Hi Fan, Really thank for your response and testing! > -----Original Message----- > From: Zhang, Roy Fan [mailto:roy.fan.zhang@intel.com] > Sent: Wednesday, March 21, 2018 12:09 PM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > thomas@monjalon.net; Gonglei (Arei) ; Zeng, Xin > ; Huangweidong (C) ; wangxi= n (U) > ; longpeng ; Zhang, Roy= Fan > > Subject: RE: [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices >=20 > Hi Jay, >=20 > Excellent work! The patch, although need some minor rework, has improved = the > performance. > Some comments: >=20 > 1. you need to set up capabilities for virtio_crypto PMD. As in Qemu vhos= t > crypto proxy backend only AESCBC and SHA1 are supported (in > cryptodev_vhost_user_init() definition), I believe in this version these = two > algorithms shall be enough. Actually for the same reason I suggest you t= o > remove all AES_CTR test cases in the virtio_crypto PMD functional test, a= s > they will fail when vhost_user crypto backend is used. >=20 > You may use driver/crypto/qat/qat_crypto_capabilities.h as example. The c= onst > capabilities array shall be returned to the application when > virtio_crypto_dev_info_get() is called. Okay. Thank for your suggestion. > 2. there is a bug in virtio_crypto_queue_setup(), you declared " uint32_t= i, > j;" while i may be used uninitialized later. Maybe the compiled result is different using different GCC, but will fix th= en. Regards, Jay >=20 > Regards, > Fan >=20 > > diff --git a/drivers/crypto/virtio/virtio_rxtx.c > > b/drivers/crypto/virtio/virtio_rxtx.c > > new file mode 100644 > > index 0000000..b7d8066 > > --- /dev/null > > +++ b/drivers/crypto/virtio/virtio_rxtx.c > > @@ -0,0 +1,533 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2018 HUAWEI TECHNOLOGIES CO., LTD. > > + */ > > +