From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (unknown [45.249.212.255]) by dpdk.org (Postfix) with ESMTP id F25FF5F18 for ; Fri, 30 Mar 2018 04:29:10 +0200 (CEST) Received: from DGGEMM402-HUB.china.huawei.com (unknown [172.30.72.57]) by Forcepoint Email with ESMTP id EE5B7EBE1786E; Fri, 30 Mar 2018 10:29:06 +0800 (CST) Received: from DGGEMM505-MBS.china.huawei.com ([169.254.2.114]) by DGGEMM402-HUB.china.huawei.com ([10.3.20.210]) with mapi id 14.03.0361.001; Fri, 30 Mar 2018 10:28:13 +0800 From: "Zhoujian (jay)" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "thomas@monjalon.net" , "Gonglei (Arei)" , "Zeng, Xin" , "Huangweidong (C)" , "wangxin (U)" , longpeng Thread-Topic: [PATCH v3 1/7] crypto/virtio: add virtio related fundamental functions Thread-Index: AQHTxBRHzi3ANlAhUk22tmMYUJn836Pm4aWAgAEy2UA= Date: Fri, 30 Mar 2018 02:28:12 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.19.14] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v3 1/7] crypto/virtio: add virtio related fundamental functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 02:29:11 -0000 Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > Sent: Friday, March 30, 2018 12:07 AM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: Zhang, Roy Fan ; thomas@monjalon.net; Gongle= i > (Arei) ; Zeng, Xin ; > Huangweidong (C) ; wangxin (U) > ; longpeng > Subject: RE: [PATCH v3 1/7] crypto/virtio: add virtio related fundamental > functions >=20 > Hi Jay, >=20 > > -----Original Message----- > > From: Jay Zhou [mailto:jianjay.zhou@huawei.com] > > Sent: Sunday, March 25, 2018 9:34 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Zhang, Roy > > Fan ; thomas@monjalon.net; > > arei.gonglei@huawei.com; Zeng, Xin ; > > weidong.huang@huawei.com; wangxinxin.wang@huawei.com; > > longpeng2@huawei.com; jianjay.zhou@huawei.com > > Subject: [PATCH v3 1/7] crypto/virtio: add virtio related fundamental > > functions > > > > Since there does not have the common virtio library, we have to put > > these files here. They are basically the same with virtio net related > > files with some minor changes. > > > > Signed-off-by: Jay Zhou > > --- > > config/common_base | 20 ++ > > drivers/crypto/virtio/virtio_logs.h | 47 ++++ > > drivers/crypto/virtio/virtio_pci.c | 460 > > ++++++++++++++++++++++++++++++++++++ > > drivers/crypto/virtio/virtio_pci.h | 253 ++++++++++++++++++++ > > drivers/crypto/virtio/virtio_ring.h | 137 +++++++++++ > > drivers/crypto/virtio/virtqueue.c | 43 ++++ > > drivers/crypto/virtio/virtqueue.h | 176 ++++++++++++++ > > 7 files changed, 1136 insertions(+) > > create mode 100644 drivers/crypto/virtio/virtio_logs.h > > create mode 100644 drivers/crypto/virtio/virtio_pci.c > > create mode 100644 drivers/crypto/virtio/virtio_pci.h > > create mode 100644 drivers/crypto/virtio/virtio_ring.h > > create mode 100644 drivers/crypto/virtio/virtqueue.c create mode > > 100644 drivers/crypto/virtio/virtqueue.h > > > > diff --git a/config/common_base b/config/common_base index > > ad03cf4..19d0cdd 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -482,6 +482,26 @@ > > CONFIG_RTE_LIBRTE_PMD_QAT_DEBUG_DRIVER=3Dn > > CONFIG_RTE_QAT_PMD_MAX_NB_SESSIONS=3D2048 > > > > # > > +# Compile PMD for virtio crypto devices # > > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO=3Dn > > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_INIT=3Dn > > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_SESSION=3Dn > > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_TX=3Dn > > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_RX=3Dn > > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_DRIVER=3Dn > > +CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO_DEBUG_DUMP=3Dn >=20 > Could you remove these DEBUG options? I see that they are used only for > enabling logging. > For that, we are using now dynamic logging. > Take a look at the following commit, as an example: > 510ac6f4f030 ("event/sw: support dynamic logging") Okay. Will support dynamic logging for virtio crypto pmd in the next versio= n. Regards, Jay >=20 > Pablo