From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (szxga02-in.huawei.com [45.249.212.188]) by dpdk.org (Postfix) with ESMTP id CB50E201 for ; Fri, 30 Mar 2018 04:47:31 +0200 (CEST) Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.53]) by Forcepoint Email with ESMTP id 98C439A62D70B; Fri, 30 Mar 2018 10:47:25 +0800 (CST) Received: from DGGEMM423-HUB.china.huawei.com (10.1.198.40) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 30 Mar 2018 10:43:39 +0800 Received: from DGGEMM505-MBS.china.huawei.com ([169.254.2.114]) by dggemm423-hub.china.huawei.com ([10.1.198.40]) with mapi id 14.03.0361.001; Fri, 30 Mar 2018 10:43:32 +0800 From: "Zhoujian (jay)" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "thomas@monjalon.net" , "Gonglei (Arei)" , "Zeng, Xin" , "Huangweidong (C)" , "wangxin (U)" , longpeng Thread-Topic: [PATCH v3 2/7] crpyto/virtio: add crypto related session structure Thread-Index: AQHTxBRHJFjOz88OkEOn457XMx0ELqPnR6oAgADNswA= Date: Fri, 30 Mar 2018 02:43:32 +0000 Message-ID: References: <6d8b86abf79abf3bd72d02cadc0fc40fc8dd44c9.1521964379.git.jianjay.zhou@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.19.14] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v3 2/7] crpyto/virtio: add crypto related session structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 02:47:33 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > Sent: Friday, March 30, 2018 6:12 AM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: Zhang, Roy Fan ; thomas@monjalon.net; Gongle= i > (Arei) ; Zeng, Xin ; > Huangweidong (C) ; wangxin (U) > ; longpeng > Subject: RE: [PATCH v3 2/7] crpyto/virtio: add crypto related session > structure >=20 >=20 >=20 > > -----Original Message----- > > From: Jay Zhou [mailto:jianjay.zhou@huawei.com] > > Sent: Sunday, March 25, 2018 9:34 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Zhang, Roy > > Fan ; thomas@monjalon.net; > > arei.gonglei@huawei.com; Zeng, Xin ; > > weidong.huang@huawei.com; wangxinxin.wang@huawei.com; > > longpeng2@huawei.com; jianjay.zhou@huawei.com > > Subject: [PATCH v3 2/7] crpyto/virtio: add crypto related session > > structure >=20 > Typo in title. Will fix. >=20 > > > > This structure will be used in the following patches, especially at > > creating and destroying crypto sessions. > > > > Signed-off-by: Jay Zhou > > --- > > drivers/crypto/virtio/virtio_crypto_algs.h | 27 > > +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > create mode 100644 drivers/crypto/virtio/virtio_crypto_algs.h > > > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.h > > b/drivers/crypto/virtio/virtio_crypto_algs.h > > new file mode 100644 > > index 0000000..5f1e9df > > --- /dev/null > > +++ b/drivers/crypto/virtio/virtio_crypto_algs.h > > @@ -0,0 +1,27 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2018 HUAWEI TECHNOLOGIES CO., LTD. > > + */ > > + > > +#ifndef _VIRTIO_CRYPTO_ALGS_H_ > > +#define _VIRTIO_CRYPTO_ALGS_H_ > > + > > +#include > > +#include > > + > > +struct virtio_crypto_session { > > + uint64_t session_id; >=20 > Probably a uint32_t here is enough. Consider the type of session_id in the struct virtio_crypto_op_header of linux kernel and QEMU side is uint64_t, could we just keep it as uint64_t for consistency? Regards, Jay