From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (unknown [45.249.212.255]) by dpdk.org (Postfix) with ESMTP id 0C1391B1EE for ; Mon, 16 Apr 2018 02:56:54 +0200 (CEST) Received: from DGGEMM404-HUB.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id 1F1ACC507AFFE; Mon, 16 Apr 2018 08:56:50 +0800 (CST) Received: from DGGEMM505-MBS.china.huawei.com ([169.254.2.114]) by DGGEMM404-HUB.china.huawei.com ([10.3.20.212]) with mapi id 14.03.0361.001; Mon, 16 Apr 2018 08:56:45 +0800 From: "Zhoujian (jay)" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "thomas@monjalon.net" , "Gonglei (Arei)" , "Zeng, Xin" , "Huangweidong (C)" , "wangxin (U)" , longpeng Thread-Topic: [PATCH v9 09/11] crypto/virtio: build with meson Thread-Index: AQHT1JcBeIrm+z26F0uv1a/kaXa0cqQBNcmAgAFbyJA= Date: Mon, 16 Apr 2018 00:56:45 +0000 Message-ID: References: <2c8ec2aa5f0c2b8b707fe881238670396fbee988.1523781007.git.jianjay.zhou@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.19.14] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v9 09/11] crypto/virtio: build with meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 00:56:54 -0000 Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > Sent: Sunday, April 15, 2018 8:09 PM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: Zhang, Roy Fan ; thomas@monjalon.net; Gongle= i > (Arei) ; Zeng, Xin ; > Huangweidong (C) ; wangxin (U) > ; longpeng > Subject: RE: [PATCH v9 09/11] crypto/virtio: build with meson >=20 > Hi Jay, >=20 > > -----Original Message----- > > From: Jay Zhou [mailto:jianjay.zhou@huawei.com] > > Sent: Sunday, April 15, 2018 9:51 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Zhang, Roy > > Fan ; thomas@monjalon.net; > > arei.gonglei@huawei.com; Zeng, Xin ; > > weidong.huang@huawei.com; wangxinxin.wang@huawei.com; > > longpeng2@huawei.com; jianjay.zhou@huawei.com > > Subject: [PATCH v9 09/11] crypto/virtio: build with meson > > > > Signed-off-by: Jay Zhou > > Reviewed-by: Fan Zhang > > Acked-by: Fan Zhang > > --- > > drivers/crypto/meson.build | 2 +- > > drivers/crypto/virtio/meson.build | 12 ++++++++++++ > > 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 > > drivers/crypto/virtio/meson.build > > > > diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build > > index > > 736c9f5..63649c9 100644 > > --- a/drivers/crypto/meson.build > > +++ b/drivers/crypto/meson.build > > @@ -2,7 +2,7 @@ > > # Copyright(c) 2017 Intel Corporation > > > > drivers =3D ['dpaa_sec', 'dpaa2_sec', > > - 'openssl', 'null', 'qat'] > > + 'openssl', 'null', 'qat', 'virtio'] > > > > std_deps =3D ['cryptodev'] # cryptodev pulls in all other needed deps > > config_flag_fmt =3D 'RTE_LIBRTE_@0@_PMD' > > diff --git a/drivers/crypto/virtio/meson.build > > b/drivers/crypto/virtio/meson.build > > new file mode 100644 > > index 0000000..cee77cc > > --- /dev/null > > +++ b/drivers/crypto/virtio/meson.build > > @@ -0,0 +1,12 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 HUAWEI > > +TECHNOLOGIES CO., LTD. > > + > > +dep =3D dependency('libcrypto', required: false) if not dep.found() > > + build =3D false > > +endif > > +deps +=3D ['bus_pci'] > > +sources =3D files('virtio_cryptodev.c', 'virtio_pci.c', > > + 'virtio_rxtx.c', 'virtqueue.c') > > +ext_deps +=3D dep > > +pkgconfig_extra_libs +=3D '-lcrypto' > > -- > > 1.8.3.1 > > >=20 > Could you add this build from the first patch? Basically, every time you = make > a change in the Makefile, you should do the same in meson.build. I'll split this patch into two parts and squash them into the first and the= second patch. Thanks for your suggestion. Regards, Jay >=20 > Thanks, > Pablo