From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (szxga03-in.huawei.com [45.249.212.189]) by dpdk.org (Postfix) with ESMTP id 9188CAAF5 for ; Mon, 16 Apr 2018 17:18:48 +0200 (CEST) Received: from DGGEMM401-HUB.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id 7AA6ADBE39316; Mon, 16 Apr 2018 23:18:43 +0800 (CST) Received: from DGGEMM421-HUB.china.huawei.com (10.1.198.38) by DGGEMM401-HUB.china.huawei.com (10.3.20.209) with Microsoft SMTP Server (TLS) id 14.3.361.1; Mon, 16 Apr 2018 23:18:44 +0800 Received: from DGGEMM505-MBS.china.huawei.com ([169.254.2.114]) by dggemm421-hub.china.huawei.com ([10.1.198.38]) with mapi id 14.03.0361.001; Mon, 16 Apr 2018 23:18:36 +0800 From: "Zhoujian (jay)" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "thomas@monjalon.net" , "Gonglei (Arei)" , "Zeng, Xin" , "Huangweidong (C)" , "wangxin (U)" , longpeng Thread-Topic: [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD Thread-Index: AQHT1SmrKiiN1QFevUq//Gaga1c2WqQC6mwAgACQKoA= Date: Mon, 16 Apr 2018 15:18:35 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.19.14] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 15:18:49 -0000 Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > Sent: Monday, April 16, 2018 10:16 PM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: Zhang, Roy Fan ; thomas@monjalon.net; Gongle= i > (Arei) ; Zeng, Xin ; > Huangweidong (C) ; wangxin (U) > ; longpeng > Subject: RE: [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD >=20 > Hi Jay, >=20 > > -----Original Message----- > > From: Jay Zhou [mailto:jianjay.zhou@huawei.com] > > Sent: Monday, April 16, 2018 3:21 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Zhang, Roy > > Fan ; thomas@monjalon.net; > > arei.gonglei@huawei.com; Zeng, Xin ; > > weidong.huang@huawei.com; wangxinxin.wang@huawei.com; > > longpeng2@huawei.com; jianjay.zhou@huawei.com > > Subject: [PATCH v10 01/10] crypto/virtio: add virtio crypto PMD > > > > The virtio crypto device is a virtual cryptography device as well as a > > kind of virtual hardware accelerator for virtual machines. The linux > > kernel virtio-crypto driver has been merged, and this patch introduces > > virtio crypto PMD to achieve better performance. > > > > Signed-off-by: Jay Zhou > > Reviewed-by: Fan Zhang > > Acked-by: Fan Zhang >=20 > ... >=20 > > +++ b/drivers/crypto/virtio/meson.build > > @@ -0,0 +1,11 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 HUAWEI > > +TECHNOLOGIES CO., LTD. > > + > > +dep =3D dependency('libcrypto', required: false) if not dep.found() > > + build =3D false > > +endif >=20 > Does this PMD have a dependency on libcrypto? > Looking at the code, I don't think it does. > Therefore, you should remove this and also LDLIBS +=3D -lcrypto in the Ma= kefile. It's compiled successfully without the dependency, so you're right. I'll re= move it. > Once this is removed, and you add the path to the virtio_crypto.h file (a= s > Ferruh suggested), I'd say this PMD can be enabled by default. I agree with you and Ferruh. If the other codes are fine for you, I'll send the next version tomorrow with this PMD enabled by default as well as the updated path to virtio_crypto.h file. Regards, Jay