From: "Zhoujian (jay)" <jianjay.zhou@huawei.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
"roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag
Date: Mon, 18 May 2020 01:03:01 +0000 [thread overview]
Message-ID: <B2D15215269B544CADD246097EACE7474BCB301F@DGGEMM528-MBX.china.huawei.com> (raw)
In-Reply-To: <VI1PR04MB316865DA0B21846C2B07AFC8E6BD0@VI1PR04MB3168.eurprd04.prod.outlook.com>
Hi Akhil,
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Saturday, May 16, 2020 1:08 AM
> To: Zhoujian (jay) <jianjay.zhou@huawei.com>; dev@dpdk.org
> Cc: pablo.de.lara.guarch@intel.com; roy.fan.zhang@intel.com; Huangweidong
> (C) <weidong.huang@huawei.com>
> Subject: RE: [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag
>
> Hi Jay,
>
>
> >
> > Since it will check the feature mask before running out-of-place test
> > cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> >
> Is this feature already supported in the PMD and this patch is a fix to the original
> patch.
Yes.
> If that is the case, title should be
> Crypto/virtio: add missing OOP feature flag Also add a fixes line to link the original
> feature patch.
The OOP_LB_IN_LB_OUT function is introduced by commit 82adb12a
(crypto/virtio: support burst enqueue/dequeue), but the OOP_LB_IN_LB_OUT
feature flag is introduced after that, which is commit 2717246e
(cryptodev: replace mbuf scatter gather flag), I'm not sure which one should be added.
Regards,
Jay Zhou
>
> > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > ---
prev parent reply other threads:[~2020-05-18 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 9:31 Jay Zhou
2020-05-15 17:07 ` Akhil Goyal
2020-05-17 13:18 ` Akhil Goyal
2020-05-17 14:17 ` Akhil Goyal
2020-05-18 1:07 ` Zhoujian (jay)
2020-05-18 1:03 ` Zhoujian (jay) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B2D15215269B544CADD246097EACE7474BCB301F@DGGEMM528-MBX.china.huawei.com \
--to=jianjay.zhou@huawei.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).