DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag
@ 2020-05-15  9:31 Jay Zhou
  2020-05-15 17:07 ` Akhil Goyal
  0 siblings, 1 reply; 6+ messages in thread
From: Jay Zhou @ 2020-05-15  9:31 UTC (permalink / raw)
  To: dev
  Cc: akhil.goyal, pablo.de.lara.guarch, roy.fan.zhang, jianjay.zhou,
	weidong.huang

Since it will check the feature mask before running out-of-place
test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.

Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
---
 drivers/crypto/virtio/virtio_cryptodev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c
index e7fb71a..cdf43b0 100644
--- a/drivers/crypto/virtio/virtio_cryptodev.c
+++ b/drivers/crypto/virtio/virtio_cryptodev.c
@@ -741,7 +741,8 @@ static int virtio_crypto_sym_configure_session(struct rte_cryptodev *dev,
 	cryptodev->dequeue_burst = virtio_crypto_pkt_rx_burst;
 
 	cryptodev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |
-		RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING;
+		RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
+		RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT;
 
 	hw = cryptodev->data->dev_private;
 	hw->dev_id = cryptodev->data->dev_id;
-- 
1.8.3.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag
  2020-05-15  9:31 [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag Jay Zhou
@ 2020-05-15 17:07 ` Akhil Goyal
  2020-05-17 13:18   ` Akhil Goyal
  2020-05-18  1:03   ` Zhoujian (jay)
  0 siblings, 2 replies; 6+ messages in thread
From: Akhil Goyal @ 2020-05-15 17:07 UTC (permalink / raw)
  To: Jay Zhou, dev; +Cc: pablo.de.lara.guarch, roy.fan.zhang, weidong.huang

Hi Jay,


> 
> Since it will check the feature mask before running out-of-place
> test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> 
Is this feature already supported in the PMD and this patch is a fix to the original patch.
If that is the case, title should be
Crypto/virtio: add missing OOP feature flag
Also add a fixes line to link the original feature patch.

> Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> ---

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag
  2020-05-15 17:07 ` Akhil Goyal
@ 2020-05-17 13:18   ` Akhil Goyal
  2020-05-17 14:17     ` Akhil Goyal
  2020-05-18  1:03   ` Zhoujian (jay)
  1 sibling, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2020-05-17 13:18 UTC (permalink / raw)
  To: Akhil Goyal, Jay Zhou, dev
  Cc: pablo.de.lara.guarch, roy.fan.zhang, weidong.huang


> 
> Hi Jay,
> 
> 
> >
> > Since it will check the feature mask before running out-of-place
> > test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> >
> Is this feature already supported in the PMD and this patch is a fix to the original
> patch.
> If that is the case, title should be
> Crypto/virtio: add missing OOP feature flag
> Also add a fixes line to link the original feature patch.
> 
> > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > ---

The feature is also not added in the documentation
doc/guides/cryptodevs/features/virtio.ini



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag
  2020-05-17 13:18   ` Akhil Goyal
@ 2020-05-17 14:17     ` Akhil Goyal
  2020-05-18  1:07       ` Zhoujian (jay)
  0 siblings, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2020-05-17 14:17 UTC (permalink / raw)
  To: Jay Zhou, dev; +Cc: pablo.de.lara.guarch, roy.fan.zhang, weidong.huang

> 
> >
> > Hi Jay,
> >
> >
> > >
> > > Since it will check the feature mask before running out-of-place
> > > test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> > >
> > Is this feature already supported in the PMD and this patch is a fix to the
> original
> > patch.
> > If that is the case, title should be
> > Crypto/virtio: add missing OOP feature flag
> > Also add a fixes line to link the original feature patch.
> >
> > > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > > ---
> 
> The feature is also not added in the documentation
> doc/guides/cryptodevs/features/virtio.ini
> 

I have done the required changes myself while merging the patch as we
Need to close the tree for RC3.
Please have a look.

Thanks.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag
  2020-05-15 17:07 ` Akhil Goyal
  2020-05-17 13:18   ` Akhil Goyal
@ 2020-05-18  1:03   ` Zhoujian (jay)
  1 sibling, 0 replies; 6+ messages in thread
From: Zhoujian (jay) @ 2020-05-18  1:03 UTC (permalink / raw)
  To: Akhil Goyal, dev; +Cc: pablo.de.lara.guarch, roy.fan.zhang, Huangweidong (C)

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Saturday, May 16, 2020 1:08 AM
> To: Zhoujian (jay) <jianjay.zhou@huawei.com>; dev@dpdk.org
> Cc: pablo.de.lara.guarch@intel.com; roy.fan.zhang@intel.com; Huangweidong
> (C) <weidong.huang@huawei.com>
> Subject: RE: [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag
> 
> Hi Jay,
> 
> 
> >
> > Since it will check the feature mask before running out-of-place test
> > cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> >
> Is this feature already supported in the PMD and this patch is a fix to the original
> patch.

Yes.

> If that is the case, title should be
> Crypto/virtio: add missing OOP feature flag Also add a fixes line to link the original
> feature patch.

The OOP_LB_IN_LB_OUT function is introduced by commit 82adb12a 
(crypto/virtio: support burst enqueue/dequeue), but the OOP_LB_IN_LB_OUT
feature flag is introduced after that, which is commit 2717246e
(cryptodev: replace mbuf scatter gather flag), I'm not sure which one should be added.

Regards,
Jay Zhou

> 
> > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > ---

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag
  2020-05-17 14:17     ` Akhil Goyal
@ 2020-05-18  1:07       ` Zhoujian (jay)
  0 siblings, 0 replies; 6+ messages in thread
From: Zhoujian (jay) @ 2020-05-18  1:07 UTC (permalink / raw)
  To: Akhil Goyal, dev; +Cc: pablo.de.lara.guarch, roy.fan.zhang, Huangweidong (C)



> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Sunday, May 17, 2020 10:18 PM
> To: Zhoujian (jay) <jianjay.zhou@huawei.com>; dev@dpdk.org
> Cc: pablo.de.lara.guarch@intel.com; roy.fan.zhang@intel.com; Huangweidong
> (C) <weidong.huang@huawei.com>
> Subject: RE: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature
> flag
> 
> >
> > >
> > > Hi Jay,
> > >
> > >
> > > >
> > > > Since it will check the feature mask before running out-of-place
> > > > test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> > > >
> > > Is this feature already supported in the PMD and this patch is a fix
> > > to the
> > original
> > > patch.
> > > If that is the case, title should be
> > > Crypto/virtio: add missing OOP feature flag Also add a fixes line to
> > > link the original feature patch.
> > >
> > > > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > > > ---
> >
> > The feature is also not added in the documentation
> > doc/guides/cryptodevs/features/virtio.ini
> >

Oh, Yes.

> 
> I have done the required changes myself while merging the patch as we Need to
> close the tree for RC3.
> Please have a look.

Thanks for helping to do it. BTW, should we add the "Fixes:" line in the patch?

Regards,
Jay Zhou

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-05-18  1:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15  9:31 [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag Jay Zhou
2020-05-15 17:07 ` Akhil Goyal
2020-05-17 13:18   ` Akhil Goyal
2020-05-17 14:17     ` Akhil Goyal
2020-05-18  1:07       ` Zhoujian (jay)
2020-05-18  1:03   ` Zhoujian (jay)

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git