From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8AB1A0093; Mon, 18 May 2020 03:03:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA4741D559; Mon, 18 May 2020 03:03:12 +0200 (CEST) Received: from huawei.com (szxga01-in.huawei.com [45.249.212.187]) by dpdk.org (Postfix) with ESMTP id 7DCE91D558 for ; Mon, 18 May 2020 03:03:11 +0200 (CEST) Received: from DGGEMM405-HUB.china.huawei.com (unknown [172.30.72.53]) by Forcepoint Email with ESMTP id 18B5EC37FD5F86C7CCE1; Mon, 18 May 2020 09:03:10 +0800 (CST) Received: from DGGEMM423-HUB.china.huawei.com (10.1.198.40) by DGGEMM405-HUB.china.huawei.com (10.3.20.213) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 18 May 2020 09:03:09 +0800 Received: from DGGEMM528-MBX.china.huawei.com ([169.254.8.13]) by dggemm423-hub.china.huawei.com ([10.1.198.40]) with mapi id 14.03.0487.000; Mon, 18 May 2020 09:03:01 +0800 From: "Zhoujian (jay)" To: Akhil Goyal , "dev@dpdk.org" CC: "pablo.de.lara.guarch@intel.com" , "roy.fan.zhang@intel.com" , "Huangweidong (C)" Thread-Topic: [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag Thread-Index: AQHWKpukGfhjFl/1B0yhGSe333i8SKio21mAgAQuIrA= Date: Mon, 18 May 2020 01:03:01 +0000 Message-ID: References: <20200515093127.1471-1-jianjay.zhou@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.149.93] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Saturday, May 16, 2020 1:08 AM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: pablo.de.lara.guarch@intel.com; roy.fan.zhang@intel.com; Huangweidong > (C) > Subject: RE: [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag >=20 > Hi Jay, >=20 >=20 > > > > Since it will check the feature mask before running out-of-place test > > cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode. > > > Is this feature already supported in the PMD and this patch is a fix to t= he original > patch. Yes. > If that is the case, title should be > Crypto/virtio: add missing OOP feature flag Also add a fixes line to link= the original > feature patch. The OOP_LB_IN_LB_OUT function is introduced by commit 82adb12a=20 (crypto/virtio: support burst enqueue/dequeue), but the OOP_LB_IN_LB_OUT feature flag is introduced after that, which is commit 2717246e (cryptodev: replace mbuf scatter gather flag), I'm not sure which one shoul= d be added. Regards, Jay Zhou >=20 > > Signed-off-by: Jay Zhou > > ---