Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag

["Zhoujian (jay)" <jianjay.zhou@huawei.com>]

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Sunday, May 17, 2020 10:18 PM
> To: Zhoujian (jay) <jianjay.zhou@huawei.com>; dev@dpdk.org
> Cc: pablo.de.lara.guarch@intel.com; roy.fan.zhang@intel.com; Huangweidong
> (C) <weidong.huang@huawei.com>
> Subject: RE: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature
> flag
> 
> >
> > >
> > > Hi Jay,
> > >
> > >
> > > >
> > > > Since it will check the feature mask before running out-of-place
> > > > test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> > > >
> > > Is this feature already supported in the PMD and this patch is a fix
> > > to the
> > original
> > > patch.
> > > If that is the case, title should be
> > > Crypto/virtio: add missing OOP feature flag Also add a fixes line to
> > > link the original feature patch.
> > >
> > > > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > > > ---
> >
> > The feature is also not added in the documentation
> > doc/guides/cryptodevs/features/virtio.ini
> >

Oh, Yes.

> 
> I have done the required changes myself while merging the patch as we Need to
> close the tree for RC3.
> Please have a look.

Thanks for helping to do it. BTW, should we add the "Fixes:" line in the patch?

Regards,
Jay Zhou