From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED5AAA0093; Mon, 18 May 2020 03:07:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C827B1D55B; Mon, 18 May 2020 03:07:56 +0200 (CEST) Received: from huawei.com (szxga01-in.huawei.com [45.249.212.187]) by dpdk.org (Postfix) with ESMTP id 9C4171D559 for ; Mon, 18 May 2020 03:07:54 +0200 (CEST) Received: from DGGEMM404-HUB.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id 7C8F5CB010427FB4E14C; Mon, 18 May 2020 09:07:53 +0800 (CST) Received: from DGGEMM424-HUB.china.huawei.com (10.1.198.41) by DGGEMM404-HUB.china.huawei.com (10.3.20.212) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 18 May 2020 09:07:39 +0800 Received: from DGGEMM528-MBX.china.huawei.com ([169.254.8.13]) by dggemm424-hub.china.huawei.com ([10.1.198.41]) with mapi id 14.03.0487.000; Mon, 18 May 2020 09:07:30 +0800 From: "Zhoujian (jay)" To: Akhil Goyal , "dev@dpdk.org" CC: "pablo.de.lara.guarch@intel.com" , "roy.fan.zhang@intel.com" , "Huangweidong (C)" Thread-Topic: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag Thread-Index: AQHWLE21HZC7sC/61U62WlVONwhVm6irzTYAgAE6YfA= Date: Mon, 18 May 2020 01:07:29 +0000 Message-ID: References: <20200515093127.1471-1-jianjay.zhou@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.149.93] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Sunday, May 17, 2020 10:18 PM > To: Zhoujian (jay) ; dev@dpdk.org > Cc: pablo.de.lara.guarch@intel.com; roy.fan.zhang@intel.com; Huangweidong > (C) > Subject: RE: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT featu= re > flag >=20 > > > > > > > > Hi Jay, > > > > > > > > > > > > > > Since it will check the feature mask before running out-of-place > > > > test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT m= ode. > > > > > > > Is this feature already supported in the PMD and this patch is a fix > > > to the > > original > > > patch. > > > If that is the case, title should be > > > Crypto/virtio: add missing OOP feature flag Also add a fixes line to > > > link the original feature patch. > > > > > > > Signed-off-by: Jay Zhou > > > > --- > > > > The feature is also not added in the documentation > > doc/guides/cryptodevs/features/virtio.ini > > Oh, Yes. >=20 > I have done the required changes myself while merging the patch as we Nee= d to > close the tree for RC3. > Please have a look. Thanks for helping to do it. BTW, should we add the "Fixes:" line in the pa= tch? Regards, Jay Zhou