Re: [dpdk-dev] [PATCH] net: redefine array size macros

[Andrew Boyer <aboyer@pensando.io>]

> On Feb 1, 2021, at 5:28 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> 29/01/2021 23:44, Andrew Boyer:
>> Replace copies of size(arr)/size(arr[0]) with RTE_DIM().
>> Eventually all of these macro definitions should be removed.
>> 
>> Signed-off-by: Andrew Boyer <aboyer@pensando.io>
>> ---
>> drivers/net/atlantic/atl_hw_regs.h                | 2 +-
>> drivers/net/axgbe/axgbe_common.h                  | 2 +-
>> drivers/net/bnx2x/bnx2x.h                         | 2 +-
>> drivers/net/bnx2x/elink.h                         | 2 +-
>> drivers/net/ena/ena_ethdev.c                      | 2 +-
>> drivers/net/enic/base/vnic_devcmd.h               | 2 +-
>> drivers/net/hns3/hns3_ethdev.h                    | 2 +-
>> drivers/net/i40e/base/i40e_osdep.h                | 2 +-
>> drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 2 +-
>> drivers/net/thunderx/base/nicvf_hw.h              | 2 +-
>> 10 files changed, 10 insertions(+), 10 deletions(-)
> 
> Thanks for the cleanup.
> 
> In the title, the prefix "net" means librte_net.
> Here, it should be "drivers/net". I know it's confusing :)
> 
> Please check other patches in the series,
> they are versioned as v2 and numbered 4/13 and 6/13.

Thank you for the review - do you want me to resend or can you fix it up yourself?

The 4/13 and 6/13 are fixups that Ferruh asked for, while he applied the rest of the series. I made the 4/13 a v2 replying to the original 4/13 and the 6/13 a v2 replying to the original 6/13. If I messed it up, my apologies!

-Andrew