From: Dharmik Thakkar <Dharmik.Thakkar@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Wang, Yipeng1" <yipeng1.wang@intel.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"zhongdahulinfan@163.com" <zhongdahulinfan@163.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4 1/3] hash: fix position bug in 'free key with position'
Date: Thu, 9 May 2019 20:30:20 +0000 [thread overview]
Message-ID: <B61860C9-C33A-441C-A929-ACC52B19827E@arm.com> (raw)
In-Reply-To: <1747192.QZgYevTSIy@xps>
> On May 9, 2019, at 3:23 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 09/05/2019 22:14, Dharmik Thakkar:
>>> On May 9, 2019, at 2:27 PM, Wang, Yipeng1 <yipeng1.wang@intel.com> wrote:
>>>> - RETURN_IF_TRUE(((h == NULL) || (position == EMPTY_SLOT)), -EINVAL);
>>>> + /* Key index where key is stored, adding the first dummy index*/
>>> [Wang, Yipeng] Minor issue, missing a space at the end.
>> Is there a need to update the version?
>
> No, I am applying.
Sounds good. Thank you, Thomas!
>
>
>
next prev parent reply other threads:[~2019-05-09 20:30 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 16:51 [dpdk-dev] [PATCH 0/2] hash: fix bugs " Dharmik Thakkar
2019-05-08 16:51 ` Dharmik Thakkar
2019-05-08 16:51 ` [dpdk-dev] [PATCH 1/2] " Dharmik Thakkar
2019-05-08 16:51 ` Dharmik Thakkar
2019-05-08 16:51 ` [dpdk-dev] [PATCH 2/2] test/hash: add test for " Dharmik Thakkar
2019-05-08 16:51 ` Dharmik Thakkar
2019-05-08 20:11 ` Wang, Yipeng1
2019-05-08 20:11 ` Wang, Yipeng1
2019-05-08 22:54 ` Dharmik Thakkar
2019-05-08 22:54 ` Dharmik Thakkar
2019-05-08 22:59 ` [dpdk-dev] [PATCH v2 0/2] hash: fix bugs in " Dharmik Thakkar
2019-05-08 22:59 ` Dharmik Thakkar
2019-05-08 22:59 ` [dpdk-dev] [PATCH v2 1/2] " Dharmik Thakkar
2019-05-08 22:59 ` Dharmik Thakkar
2019-05-09 8:29 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-09 8:29 ` Thomas Monjalon
2019-05-09 10:40 ` 胡林帆
2019-05-09 10:40 ` 胡林帆
2019-05-09 11:25 ` Thomas Monjalon
2019-05-09 11:25 ` Thomas Monjalon
2019-05-09 12:38 ` Dharmik Thakkar
2019-05-09 12:38 ` Dharmik Thakkar
2019-05-08 22:59 ` [dpdk-dev] [PATCH v2 2/2] test/hash: add test for " Dharmik Thakkar
2019-05-08 22:59 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 0/3] hash: fix bugs in " Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 1/3] hash: fix position bug " Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 15:48 ` Wang, Yipeng1
2019-05-09 15:48 ` Wang, Yipeng1
2019-05-09 17:25 ` Dharmik Thakkar
2019-05-09 17:25 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 2/3] hash: fix total entries in free key with position Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 13:39 ` [dpdk-dev] [PATCH v3 3/3] test/hash: add test for 'free key with position' Dharmik Thakkar
2019-05-09 13:39 ` Dharmik Thakkar
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in " Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 1/3] hash: fix position bug " Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 19:27 ` Wang, Yipeng1
2019-05-09 19:27 ` Wang, Yipeng1
2019-05-09 20:14 ` Dharmik Thakkar
2019-05-09 20:14 ` Dharmik Thakkar
2019-05-09 20:23 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-09 20:23 ` Thomas Monjalon
2019-05-09 20:30 ` Dharmik Thakkar [this message]
2019-05-09 20:30 ` Dharmik Thakkar
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 2/3] hash: fix total entries in free key with position Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 19:32 ` Wang, Yipeng1
2019-05-09 19:32 ` Wang, Yipeng1
2019-05-09 17:19 ` [dpdk-dev] [PATCH v4 3/3] test/hash: add test for 'free key with position' Dharmik Thakkar
2019-05-09 17:19 ` Dharmik Thakkar
2019-05-09 19:33 ` Wang, Yipeng1
2019-05-09 19:33 ` Wang, Yipeng1
2019-05-09 19:24 ` [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in " Thomas Monjalon
2019-05-09 19:24 ` Thomas Monjalon
2019-05-09 19:36 ` Wang, Yipeng1
2019-05-09 19:36 ` Wang, Yipeng1
2019-05-09 20:36 ` Thomas Monjalon
2019-05-09 20:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B61860C9-C33A-441C-A929-ACC52B19827E@arm.com \
--to=dharmik.thakkar@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yipeng1.wang@intel.com \
--cc=zhongdahulinfan@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).