From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Dharmik.Thakkar@arm.com> Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60079.outbound.protection.outlook.com [40.107.6.79]) by dpdk.org (Postfix) with ESMTP id D7A572C18; Thu, 9 May 2019 22:30:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SdRksojm++RY2/FY3ONCjWUk5p/wVJvFtl5meGF25pU=; b=gdjDfJQMn1fQJ5KO12KNZfkA8ob96j+XOek8IOeZVKhTtOl+bYNuHEm0ibEID4G5WY4ltmGA4lQbRj9nuP7Fq2V2kp6PH1u42rSOnJFN9wZeDmu3tCLk1uL9tFHWxaAeK62vEg3J2/a1At/qIBMsUbyeuvKz93r+Wr7ndnc2Ais= Received: from AM0PR08MB3379.eurprd08.prod.outlook.com (20.177.109.142) by AM0PR08MB3009.eurprd08.prod.outlook.com (52.134.126.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Thu, 9 May 2019 20:30:20 +0000 Received: from AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::b5af:c4b5:376e:ab19]) by AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::b5af:c4b5:376e:ab19%7]) with mapi id 15.20.1856.012; Thu, 9 May 2019 20:30:20 +0000 From: Dharmik Thakkar <Dharmik.Thakkar@arm.com> To: "thomas@monjalon.net" <thomas@monjalon.net> CC: "stable@dpdk.org" <stable@dpdk.org>, "Wang, Yipeng1" <yipeng1.wang@intel.com>, "Gobriel, Sameh" <sameh.gobriel@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "zhongdahulinfan@163.com" <zhongdahulinfan@163.com>, nd <nd@arm.com> Thread-Topic: [dpdk-stable] [PATCH v4 1/3] hash: fix position bug in 'free key with position' Thread-Index: AQHVBottn/LXLfjjpk6YR4JCNbbiYqZjLWAAgAANDoCAAAK/gIAAAcYA Date: Thu, 9 May 2019 20:30:20 +0000 Message-ID: <B61860C9-C33A-441C-A929-ACC52B19827E@arm.com> References: <20190509133924.7153-1-dharmik.thakkar@arm.com> <D2C4A16CA39F7F4E8E384D204491D7A673E5E941@ORSMSX104.amr.corp.intel.com> <BC151016-8C0D-416D-80F6-39085BA0ED09@arm.com> <1747192.QZgYevTSIy@xps> In-Reply-To: <1747192.QZgYevTSIy@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Dharmik.Thakkar@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e8eca492-76d4-4dc9-6c1a-08d6d4bd282a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR08MB3009; x-ms-traffictypediagnostic: AM0PR08MB3009: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: <AM0PR08MB300963F347B157866EFD8EB0FB330@AM0PR08MB3009.eurprd08.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 003245E729 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39860400002)(396003)(136003)(189003)(199004)(186003)(102836004)(26005)(76176011)(7736002)(82746002)(229853002)(4744005)(478600001)(36756003)(2351001)(66066001)(305945005)(72206003)(5660300002)(83716004)(86362001)(256004)(71200400001)(71190400001)(91956017)(14444005)(66446008)(6506007)(53546011)(76116006)(73956011)(64756008)(66556008)(66946007)(66476007)(25786009)(2906002)(53936002)(6512007)(3846002)(8676002)(81166006)(6246003)(446003)(33656002)(81156014)(476003)(2616005)(11346002)(486006)(68736007)(316002)(6486002)(2501003)(99286004)(6916009)(54906003)(5640700003)(4326008)(8936002)(6116002)(1730700003)(6436002)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3009; H:AM0PR08MB3379.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: J7WE8BnhgfD89X38AVXlvHubFTHBP/4xQ/kKTh7WRjk8Ws1VwTazf7D4m5lhzmCNvoOw4fKebwfHKrS2R4E+425sVov6scw2WWWiuA2f4HHJi7tgqwtZSezMGrEpRQkBiJ4a8KIDNp6GQR+t956py2L9ZESCL1fDEKLlsVE7Oo8Qq4Nbuk7xekjDA5y6UHTYPAoLuMNsKSwH25ZwNv0Ot52yyf3BRSe3toQXHS06pgBzZetd1lS80qXC4gkxV6Auj3fUrFYszmL38k/D5p6XN9Qf+K8NPr2VXn6yVYg9ututGkGLYNFppJdAixLe4I1MIlu9Vf9lSrSIzb4jn2cbS/zEOKZVy4lnqXS/7aXs42EUpfmIWMjahfEdMHBP/v/wnqTXWqYAYaUD0MAZ+8rlt0vrUURsnRjnM3qGcMiwWMo= Content-Type: text/plain; charset="us-ascii" Content-ID: <A18A77CE478C3546A546311ADA8E328A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8eca492-76d4-4dc9-6c1a-08d6d4bd282a X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2019 20:30:20.6850 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3009 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4 1/3] hash: fix position bug in 'free key with position' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 09 May 2019 20:30:22 -0000 > On May 9, 2019, at 3:23 PM, Thomas Monjalon <thomas@monjalon.net> wrote: >=20 > 09/05/2019 22:14, Dharmik Thakkar: >>> On May 9, 2019, at 2:27 PM, Wang, Yipeng1 <yipeng1.wang@intel.com> wrot= e: >>>> - RETURN_IF_TRUE(((h =3D=3D NULL) || (position =3D=3D EMPTY_SLOT)), -E= INVAL); >>>> + /* Key index where key is stored, adding the first dummy index*/ >>> [Wang, Yipeng] Minor issue, missing a space at the end. >> Is there a need to update the version? >=20 > No, I am applying. Sounds good. Thank you, Thomas! >=20 >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 71CB3A0096 for <public@inbox.dpdk.org>; Thu, 9 May 2019 22:30:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53A9B44C3; Thu, 9 May 2019 22:30:23 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60079.outbound.protection.outlook.com [40.107.6.79]) by dpdk.org (Postfix) with ESMTP id D7A572C18; Thu, 9 May 2019 22:30:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SdRksojm++RY2/FY3ONCjWUk5p/wVJvFtl5meGF25pU=; b=gdjDfJQMn1fQJ5KO12KNZfkA8ob96j+XOek8IOeZVKhTtOl+bYNuHEm0ibEID4G5WY4ltmGA4lQbRj9nuP7Fq2V2kp6PH1u42rSOnJFN9wZeDmu3tCLk1uL9tFHWxaAeK62vEg3J2/a1At/qIBMsUbyeuvKz93r+Wr7ndnc2Ais= Received: from AM0PR08MB3379.eurprd08.prod.outlook.com (20.177.109.142) by AM0PR08MB3009.eurprd08.prod.outlook.com (52.134.126.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Thu, 9 May 2019 20:30:20 +0000 Received: from AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::b5af:c4b5:376e:ab19]) by AM0PR08MB3379.eurprd08.prod.outlook.com ([fe80::b5af:c4b5:376e:ab19%7]) with mapi id 15.20.1856.012; Thu, 9 May 2019 20:30:20 +0000 From: Dharmik Thakkar <Dharmik.Thakkar@arm.com> To: "thomas@monjalon.net" <thomas@monjalon.net> CC: "stable@dpdk.org" <stable@dpdk.org>, "Wang, Yipeng1" <yipeng1.wang@intel.com>, "Gobriel, Sameh" <sameh.gobriel@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "zhongdahulinfan@163.com" <zhongdahulinfan@163.com>, nd <nd@arm.com> Thread-Topic: [dpdk-stable] [PATCH v4 1/3] hash: fix position bug in 'free key with position' Thread-Index: AQHVBottn/LXLfjjpk6YR4JCNbbiYqZjLWAAgAANDoCAAAK/gIAAAcYA Date: Thu, 9 May 2019 20:30:20 +0000 Message-ID: <B61860C9-C33A-441C-A929-ACC52B19827E@arm.com> References: <20190509133924.7153-1-dharmik.thakkar@arm.com> <D2C4A16CA39F7F4E8E384D204491D7A673E5E941@ORSMSX104.amr.corp.intel.com> <BC151016-8C0D-416D-80F6-39085BA0ED09@arm.com> <1747192.QZgYevTSIy@xps> In-Reply-To: <1747192.QZgYevTSIy@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Dharmik.Thakkar@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e8eca492-76d4-4dc9-6c1a-08d6d4bd282a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR08MB3009; x-ms-traffictypediagnostic: AM0PR08MB3009: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: <AM0PR08MB300963F347B157866EFD8EB0FB330@AM0PR08MB3009.eurprd08.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 003245E729 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39860400002)(396003)(136003)(189003)(199004)(186003)(102836004)(26005)(76176011)(7736002)(82746002)(229853002)(4744005)(478600001)(36756003)(2351001)(66066001)(305945005)(72206003)(5660300002)(83716004)(86362001)(256004)(71200400001)(71190400001)(91956017)(14444005)(66446008)(6506007)(53546011)(76116006)(73956011)(64756008)(66556008)(66946007)(66476007)(25786009)(2906002)(53936002)(6512007)(3846002)(8676002)(81166006)(6246003)(446003)(33656002)(81156014)(476003)(2616005)(11346002)(486006)(68736007)(316002)(6486002)(2501003)(99286004)(6916009)(54906003)(5640700003)(4326008)(8936002)(6116002)(1730700003)(6436002)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3009; H:AM0PR08MB3379.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: J7WE8BnhgfD89X38AVXlvHubFTHBP/4xQ/kKTh7WRjk8Ws1VwTazf7D4m5lhzmCNvoOw4fKebwfHKrS2R4E+425sVov6scw2WWWiuA2f4HHJi7tgqwtZSezMGrEpRQkBiJ4a8KIDNp6GQR+t956py2L9ZESCL1fDEKLlsVE7Oo8Qq4Nbuk7xekjDA5y6UHTYPAoLuMNsKSwH25ZwNv0Ot52yyf3BRSe3toQXHS06pgBzZetd1lS80qXC4gkxV6Auj3fUrFYszmL38k/D5p6XN9Qf+K8NPr2VXn6yVYg9ututGkGLYNFppJdAixLe4I1MIlu9Vf9lSrSIzb4jn2cbS/zEOKZVy4lnqXS/7aXs42EUpfmIWMjahfEdMHBP/v/wnqTXWqYAYaUD0MAZ+8rlt0vrUURsnRjnM3qGcMiwWMo= Content-Type: text/plain; charset="UTF-8" Content-ID: <A18A77CE478C3546A546311ADA8E328A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8eca492-76d4-4dc9-6c1a-08d6d4bd282a X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2019 20:30:20.6850 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3009 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4 1/3] hash: fix position bug in 'free key with position' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190509203020._pXhwIA3pxoMzJZ4nhh2nq1JkmTM3keXwZiEFlu7QdE@z> > On May 9, 2019, at 3:23 PM, Thomas Monjalon <thomas@monjalon.net> wrote: >=20 > 09/05/2019 22:14, Dharmik Thakkar: >>> On May 9, 2019, at 2:27 PM, Wang, Yipeng1 <yipeng1.wang@intel.com> wrot= e: >>>> - RETURN_IF_TRUE(((h =3D=3D NULL) || (position =3D=3D EMPTY_SLOT)), -E= INVAL); >>>> + /* Key index where key is stored, adding the first dummy index*/ >>> [Wang, Yipeng] Minor issue, missing a space at the end. >> Is there a need to update the version? >=20 > No, I am applying. Sounds good. Thank you, Thomas! >=20 >=20 >=20