From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f177.google.com (mail-ie0-f177.google.com [209.85.223.177]) by dpdk.org (Postfix) with ESMTP id 14B1C7E80 for ; Wed, 5 Nov 2014 16:24:39 +0100 (CET) Received: by mail-ie0-f177.google.com with SMTP id tp5so917394ieb.22 for ; Wed, 05 Nov 2014 07:34:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arbor.net; s=m0; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=X8GBqyzO3n3JR5zJJD4wU+rYR2Gxwup62hUOGroPlLE=; b=Pb2T35jvqiWzPVHc9md9wCUJzn5cJiInilMQgL/5nb8BQ4lKetgGyhPJMhlO4FQBhh 5Xn7t+fa9OmHIv8m3AljUClEtW0f1z/sm1D0skYN+uQ2avvmnwE12A4jwmFuz4NdCwKM W0PRJw7+EvwRWtzV0vec+GKbjH3Vf7qL0H9Ms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=X8GBqyzO3n3JR5zJJD4wU+rYR2Gxwup62hUOGroPlLE=; b=O7nydJWeU2ZI+c67shL6M5/WYpaWRUtjDThDm3dgMH03Rjx7CSG6HNRj6BB/vtMcnw d3s+VtspKyUVAOS4aaEGIc0hRpaInRsu4jQKpn2eWXN3a0cn8deNnuBN01x+mnTGBrC6 uowGmBrozdjjlE3ctgvzIj9tPKzvg25br3VB7K/dcdzoQ/4i/dkq+qDN/FAD62xowjRf MC7JiF/Y4xSFP0C0JsXdm/R0sJY09/7BcpfkGdjGhyWoO7C6ws5LNvkDMrQCPuc7fpVM tJbaXf5U1JVXPzmDphMEzWEfjHoq5YOnDeohKAgkGaepB1YU6bmuR5DPG7ZXTITDaSWY P29Q== X-Gm-Message-State: ALoCoQnmZg/bliw0ZCsOcnooXHiZ1Y88/eZYQWOK6UUEAjsg08JY01ztOXRJOKr0qNYMj3sLtIoD X-Received: by 10.43.129.196 with SMTP id hj4mr5316042icc.21.1415201641700; Wed, 05 Nov 2014 07:34:01 -0800 (PST) Received: from [172.31.1.110] (hlfxns0187w-047055100128.dhcp-dynamic.FibreOp.ns.bellaliant.net. [47.55.100.128]) by mx.google.com with ESMTPSA id 199sm1633229ion.7.2014.11.05.07.34.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 05 Nov 2014 07:34:01 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\)) From: Aaron Campbell In-Reply-To: <3986981.sR7Aq8MzkS@xps13> Date: Wed, 5 Nov 2014 11:34:00 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu> <582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net> <3986981.sR7Aq8MzkS@xps13> To: Thomas Monjalon X-Mailer: Apple Mail (2.1990.1) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2014 15:24:39 -0000 > On Nov 4, 2014, at 3:00 PM, Thomas Monjalon = wrote: >=20 > 2014-11-03 13:02, Aaron Campbell: >>> On Jul 8, 2014, at 5:28 AM, Simon Kuenzer = wrote: >>>=20 >>> + else if (!strcmp(lgopts[option_index].name, = OPT_MASTER_LCORE)) { >>> + if (!coremask_ok) { >>> + RTE_LOG(ERR, EAL, "please = specify the master " >>> + "lcore id after = specifying " >>> + "the = coremask\n"); >>> + eal_usage(prgname); >>> + return -1; >>> + } >>=20 >>=20 >> Hi Simon, >>=20 >> I think that forcing a particular command line order is not that = clean. >> It might be better to remove the cfg->master_lcore setting from >> eal_parse_coremask(), and defer the selection of the master lcore = until >> all of the command-line options have been parsed. If =E2=80=94master-l= core was >> specified, save the value and use that, otherwise >> rte_get_next_lcore(-1, 0, 0) can return the first bit set in the = coremask. >=20 > It's not sufficient: eal_parse_master_lcore() requires cfg->lcore_role > to be set. There is a real dependency between these 2 options. > I'm going to submit a v2. Feel free to improve it with another patch. I was nit-picking; although it might be nice if the new option is given, = to verify the specified lcore is in the coremask. I will ack v2 though = and this can be improved some other time. -Aaron=