From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <liang-min.wang@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 46237E72 for <dev@dpdk.org>; Sat, 30 May 2015 18:16:05 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 30 May 2015 09:16:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,523,1427785200"; d="scan'208";a="718009560" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga001.fm.intel.com with ESMTP; 30 May 2015 09:16:04 -0700 Received: from orsmsx113.amr.corp.intel.com (10.22.240.9) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.224.2; Sat, 30 May 2015 09:16:04 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by ORSMSX113.amr.corp.intel.com (10.22.240.9) with Microsoft SMTP Server (TLS) id 14.3.224.2; Sat, 30 May 2015 09:16:03 -0700 Received: from FMSMSX110.amr.corp.intel.com ([169.254.14.46]) by FMSMSX155.amr.corp.intel.com ([169.254.5.57]) with mapi id 14.03.0224.002; Sat, 30 May 2015 09:16:03 -0700 From: "Wang, Liang-min" <liang-min.wang@intel.com> To: Stephen Hemminger <stephen@networkplumber.org>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Thread-Topic: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Thread-Index: AQHQmnDoomo5ZxYF70Oz8oQmwyPno52VIHkA//+NpAA= Date: Sat, 30 May 2015 16:16:01 +0000 Message-ID: <B6CB929FEBC10D4FAC4BCA7EF2298E2571764BCF@FMSMSX110.amr.corp.intel.com> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1432946276-9424-3-git-send-email-liang-min.wang@intel.com> <20150530084800.56e3585e@urahara> In-Reply-To: <20150530084800.56e3585e@urahara> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sat, 30 May 2015 16:16:05 -0000 >On Fri, 29 May 2015 20:37:56 -0400 >Liang-Min Larry Wang <liang-min.wang@intel.com> wrote: > >> adding a new library based upon ethdev APIs to provide API's that bear=20 >> the same functionality as ethtool_ops (linux/ethtool.h) and=20 > >net_device_ops (linux/netdevice.h). >The API's for ethtool like things are valuable, but please contain it more= . > >I think you should contain this to only those things which are in the orig= inal Linux ethtool. Adding yet another layer that calls DPDK for open/close= /start stop just adds more layers with out providing any value. > >The ones I would keep: > get_driverinfo > get_link > >The ones I would add: > cmd - for speed/duplex negotiation > eeprom - for eeprom access > eee - for energy awareness > coalesce - for packet coalescing > ringparam - to allow changing ring parameters > (existing rx config model is limiting) > pauseparam - existing flow control in DPDK is mess > gstrings/stats - map to XSTATS > test - for offline tests > dump - for register dump > features - control offload features > perm_addr - base mac address The design decision is to keep ethdev as THE interface for all the external= API, so ethtool APIs are designed based upon ethdev API. At the meantime, = the ethtool APIs are designed to enable users to migrate designs based upon= kernel-space ethtool. The open/close/start are put in place to enable quic= k migration. As for the suggestion, eeprom/ringparam/pauseparam/register-dump are on the= ir way for latter release. For other ops, I will take the feedback for futu= re planning.