From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 49ACF2716 for ; Sat, 30 May 2015 21:40:49 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 30 May 2015 12:40:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,523,1427785200"; d="scan'208";a="734267092" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga002.fm.intel.com with ESMTP; 30 May 2015 12:40:48 -0700 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.224.2; Sat, 30 May 2015 12:40:47 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by ORSMSX157.amr.corp.intel.com (10.22.240.23) with Microsoft SMTP Server (TLS) id 14.3.224.2; Sat, 30 May 2015 12:40:48 -0700 Received: from FMSMSX110.amr.corp.intel.com ([169.254.14.46]) by FMSMSX151.amr.corp.intel.com ([169.254.7.230]) with mapi id 14.03.0224.002; Sat, 30 May 2015 12:40:47 -0700 From: "Wang, Liang-min" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Thread-Index: AQHQmnDoomo5ZxYF70Oz8oQmwyPno52VIHkA//+NpACAAK9ZgP//jKbA Date: Sat, 30 May 2015 19:40:46 +0000 Message-ID: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1432946276-9424-3-git-send-email-liang-min.wang@intel.com> <20150530084800.56e3585e@urahara> <20150530122617.1bf2cd18@urahara> In-Reply-To: <20150530122617.1bf2cd18@urahara> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2015 19:40:49 -0000 On Sat, 30 May 2015 16:16:01 +0000 "Wang, Liang-min" wrote: > >The design decision is to keep ethdev as THE interface for all the exter= nal API, so ethtool APIs are designed based upon ethdev API. At the meantim= e, the ethtool APIs are designed to enable users to migrate designs based u= pon kernel-space ethtool. The open/close/start are put in place to enable q= uick migration. > >But there is no open/close/start in ethtool in kernel. >Anyway ethtool is currently on the disfavored list from kernel developers. >What about netlink or something better? > >Remember each new API creates more long term compatiablity and ABI issues. >So I am against introducing any new API that does the same thing as existi= ng API's. Just to clarify APIs supported by this ethtool api: there are net_open and = net_stop and no net_start. Both functions are put in place to support net_d= evice_ops::ndo_open and net_device_ops::ndo_close as defined in linux/netde= vice.h