From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0F9D1CE7 for ; Sun, 31 May 2015 19:30:59 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 31 May 2015 10:31:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,527,1427785200"; d="scan'208";a="734551029" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga002.fm.intel.com with ESMTP; 31 May 2015 10:30:58 -0700 Received: from orsmsx153.amr.corp.intel.com (10.22.226.247) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.224.2; Sun, 31 May 2015 10:30:58 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by ORSMSX153.amr.corp.intel.com (10.22.226.247) with Microsoft SMTP Server (TLS) id 14.3.224.2; Sun, 31 May 2015 10:30:57 -0700 Received: from FMSMSX110.amr.corp.intel.com ([169.254.14.46]) by FMSMSX113.amr.corp.intel.com ([169.254.13.51]) with mapi id 14.03.0224.002; Sun, 31 May 2015 10:30:58 -0700 From: "Wang, Liang-min" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Thread-Index: AQHQmnDoomo5ZxYF70Oz8oQmwyPno52VIHkA//+NpACAAK9ZgP//jKbAgAHZlwD//5NhwA== Date: Sun, 31 May 2015 17:30:57 +0000 Message-ID: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1432946276-9424-3-git-send-email-liang-min.wang@intel.com> <20150530084800.56e3585e@urahara> <20150530122617.1bf2cd18@urahara> <20150531094828.371263fe@urahara> In-Reply-To: <20150531094828.371263fe@urahara> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 May 2015 17:31:00 -0000 >On Sat, 30 May 2015 19:40:46 +0000 >"Wang, Liang-min" wrote: > >>=20 > >On Sat, 30 May 2015 16:16:01 +0000 > >"Wang, Liang-min" wrote: > > > >> >The design decision is to keep ethdev as THE interface for all the ex= ternal API, so ethtool APIs are designed based upon ethdev API. At the mean= time, the ethtool APIs are designed to enable users to migrate designs base= d upon kernel-space ethtool. The open/close/start are put in place to enabl= e quick migration. > >> > >>But there is no open/close/start in ethtool in kernel. > >>Anyway ethtool is currently on the disfavored list from kernel develope= rs. > >>What about netlink or something better? > >> > >>Remember each new API creates more long term compatiablity and ABI issu= es. > >>So I am against introducing any new API that does the same thing as exi= sting API's. > > >> Just to clarify APIs supported by this ethtool api: there are net_open=20 > >and net_stop and no net_start. Both functions are put in place to=20 > >support net_device_ops::ndo_open and net_device_ops::ndo_close as=20 > >defined in linux/netdevice.h > > >I get the feeling there is some use case you are not telling the list abou= t. >What kind of application would use this api only. Why or how would DPDK ap= plication be involved in net_device_ops. If you are planning on putting DPD= K in the kernel there are lots of other issues >including kernel ABI stabil= ity and licensing that need to be dealt with. (I'm manually adding ">" through my email, outlook, to make my reply. I apo= logy if I make any mistake on adding ">" in wrong place) No, we don't plan to put DPDK into kernel space, and this patch has nothing= to do with bifurcated driver that was announced for DPDK 2.0 then got scru= bbed (or deferred). In contrary, the entire ethtool API (more support is co= ming) is designed to assist applications that were designed based upon kern= el ethtool to migrate into user-space driver based DPDK libraries. Being sa= id that, as you are aware the kernel version of ndo_open/ndo_close is more = than just start and stop device. The initial implementation is to provide m= inimum functionality (strip off all the kernel related state management). I= n the future release (we need comments like yours), we will continue make i= mprovement. So this new API can be another alternative for applications to = run device management.