From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AD193C468 for ; Wed, 21 Oct 2015 18:46:54 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 21 Oct 2015 09:46:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,712,1437462000"; d="scan'208";a="816280707" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 21 Oct 2015 09:46:50 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 21 Oct 2015 09:46:50 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.155]) by fmsmsx116.amr.corp.intel.com ([169.254.2.182]) with mapi id 14.03.0248.002; Wed, 21 Oct 2015 09:46:49 -0700 From: "Wang, Liang-min" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-ethtool Thread-Index: AQHRDB7Eyn0j+LNjikGcpXlqsofnUp52Jq6A Date: Wed, 21 Oct 2015 16:46:49 +0000 Message-ID: References: <1437401571-9104-2-git-send-email-liang-min.wang@intel.com> <1437663628-18076-1-git-send-email-liang-min.wang@intel.com> <1437663628-18076-3-git-send-email-liang-min.wang@intel.com> <2579237.5XQrXtFRuP@xps13> In-Reply-To: <2579237.5XQrXtFRuP@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd-ethtool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 16:46:55 -0000 Thomas, Let's put this patch on defer list because there are related work might ta= ke a different approach. Let's only review the make file change (PATCH 1/2)= . I believe "export" is needed since the variable is shared by all the buil= d but it might be already included due to the mk file inclusion. Since Andy= is on vacation, I am not sure if he could make a comment on that. Larry > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, October 21, 2015 12:36 PM > To: Wang, Liang-min > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples: new example: l2fwd- > ethtool >=20 > 2015-07-23 11:00, Liang-Min Larry Wang: > > examples/Makefile | 1 + > > examples/l2fwd-ethtool/Makefile | 48 + > > examples/l2fwd-ethtool/l2fwd-app/Makefile | 58 ++ > > examples/l2fwd-ethtool/l2fwd-app/main.c | 1025 > ++++++++++++++++++++++ > > examples/l2fwd-ethtool/l2fwd-app/netdev_api.h | 770 > ++++++++++++++++ > > examples/l2fwd-ethtool/l2fwd-app/shared_fifo.h | 159 ++++ > > examples/l2fwd-ethtool/lib/Makefile | 57 ++ > > examples/l2fwd-ethtool/lib/rte_ethtool.c | 336 +++++++ > > examples/l2fwd-ethtool/lib/rte_ethtool.h | 385 ++++++++ > > examples/l2fwd-ethtool/nic-control/Makefile | 55 ++ > > examples/l2fwd-ethtool/nic-control/nic_control.c | 614 +++++++++++++ > > 11 files changed, 3508 insertions(+) >=20 > This patch is huge. > Please split a bit. >=20 > > --- a/examples/Makefile > > +++ b/examples/Makefile > > @@ -53,6 +53,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_KNI) +=3D kni > > DIRS-y +=3D l2fwd > > DIRS-$(CONFIG_RTE_LIBRTE_IVSHMEM) +=3D l2fwd-ivshmem > > DIRS-$(CONFIG_RTE_LIBRTE_JOBSTATS) +=3D l2fwd-jobstats > > +DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) +=3D l2fwd-ethtool > > DIRS-y +=3D l3fwd >=20 > Please keep the alphabetical order. >=20 > I do not plan to review it more. > If nobody complains, it means it's accepted.