From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id AE6EC4C70 for ; Fri, 30 Mar 2018 10:04:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Mar 2018 01:03:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,380,1517904000"; d="scan'208";a="216209286" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 30 Mar 2018 01:03:26 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 30 Mar 2018 01:03:26 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 30 Mar 2018 01:03:26 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.80]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0319.002; Fri, 30 Mar 2018 16:03:24 +0800 From: "Wu, Yanglong" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Dai, Wei" , "Xing, Beilei" Thread-Topic: [PATCH v3 1/2] net/i40e: convert to new Rx offloads API Thread-Index: AQHTx+omvnBpCV3Ark+udnyOqVsmy6Pn2poAgACQVwA= Date: Fri, 30 Mar 2018 08:03:23 +0000 Message-ID: References: <20180328020432.169643-1-yanglong.wu@intel.com> <20180330053957.160367-1-yanglong.wu@intel.com> <20180330053957.160367-2-yanglong.wu@intel.com> <039ED4275CED7440929022BC67E7061153176723@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153176723@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTU5YmJjOWMtOTkyYi00NzMzLTgyZjYtNDQxNDBlOTkzNzJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ilwvcmh1U1h1RzZzTGcxTjE4OUpKSlBHK0F4WUlNNGQ1S3JaYmJWcXJ4dnRzPSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: convert to new Rx offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 08:04:07 -0000 Hi=1B$B!$=1B(B -----Original Message----- From: Zhang, Qi Z=20 Sent: Friday, March 30, 2018 3:25 PM To: Wu, Yanglong ; dev@dpdk.org Cc: Dai, Wei ; Xing, Beilei Subject: RE: [PATCH v3 1/2] net/i40e: convert to new Rx offloads API Hi Yanglong >=20 > if (frame_size > ETHER_MAX_LEN) > - dev_data->dev_conf.rxmode.jumbo_frame =3D 1; > + dev_data->dev_conf.rxmode.offloads |=3D > + DEV_RX_OFFLOAD_JUMBO_FRAME; > else > - dev_data->dev_conf.rxmode.jumbo_frame =3D 0; > + dev_data->dev_conf.rxmode.jumbo_frame &=3D > + ~DEV_RX_OFFLOAD_JUMBO_FRAME; Typo here, should be dev_conf.rxmode.offloads &=3D thx I will fix it! >=20 > dev_data->dev_conf.rxmode.max_rx_pkt_len =3D frame_size; >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index c4dae4262..cb338def9 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c >=20 > if (frame_size > ETHER_MAX_LEN) > - dev_data->dev_conf.rxmode.jumbo_frame =3D 1; > + dev_data->dev_conf.rxmode.offloads |=3D > + DEV_RX_OFFLOAD_JUMBO_FRAME; > else > - dev_data->dev_conf.rxmode.jumbo_frame =3D 0; > - > + dev_data->dev_conf.rxmode.jumbo_frame &=3D > + ~DEV_RX_OFFLOAD_JUMBO_FRAME; Same as above Regards Qi