From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3E5F3C322 for ; Thu, 18 Feb 2016 11:25:30 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 18 Feb 2016 02:25:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,464,1449561600"; d="scan'208";a="905904436" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 18 Feb 2016 02:25:29 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 18 Feb 2016 02:25:28 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 18 Feb 2016 02:25:28 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.249]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.4]) with mapi id 14.03.0248.002; Thu, 18 Feb 2016 18:25:23 +0800 From: "Wang, Xiao W" To: "Richardson, Bruce" Thread-Topic: [PATCH v2 01/16] fm10k: use default mailbox message handler for pf Thread-Index: AQHRWLXxjtP8++N+w0ul6nO5KiNhY58uGAoAgAOhodA= Date: Thu, 18 Feb 2016 10:25:23 +0000 Message-ID: References: <1453372561-11431-16-git-send-email-xiao.w.wang@intel.com> <1453866647-16215-1-git-send-email-xiao.w.wang@intel.com> <1453866647-16215-2-git-send-email-xiao.w.wang@intel.com> <20160216105002.GC21696@bricha3-MOBL3> In-Reply-To: <20160216105002.GC21696@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 01/16] fm10k: use default mailbox message handler for pf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 10:25:30 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, February 16, 2016 6:50 PM > To: Wang, Xiao W > Cc: Chen, Jing D ; dev@dpdk.org; He, Shaopeng > > Subject: Re: [PATCH v2 01/16] fm10k: use default mailbox message handler = for > pf >=20 > On Wed, Jan 27, 2016 at 11:50:32AM +0800, Wang Xiao W wrote: > > The new share code makes fm10k_msg_update_pvid_pf function static, so > > we can not refer to it now in fm10k_ethdev.c. The registered pf > > handler is almost the same as the default pf handler, removing it has n= o > impact on mailbox. > > > > Signed-off-by: Wang Xiao W >=20 > While the patch itself looks ok, checkpatch gives a warning about the com= mit > message being too long. >=20 > WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit > description (prefer a > maximum 75 chars per line) > #6: > The new share code makes fm10k_msg_update_pvid_pf function static, so w= e > can >=20 > total: 0 errors, 1 warnings, 0 checks, 31 lines checked >=20 > Since the next patch breaks compilation, a V3 will be needed, so please f= ix this > warning in the process. I'd also ask that you run checkpatch on all patch= es > before submitting and fix any issue raised. Thanks for the comment, I used an old checkpatch.pl to check the patches, i= t gave no warning. I have updated the checkpatch.pl and got the above warning. I will rework the patch set, thanks again. >=20 > Thanks, > /Bruce